lukechilds
/
lightning
mirror of https://github.com/lukechilds/lightning.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
8668 Commits
55 Branches
107 Tags
38 MiB
Tree: 488b32b003
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '488b32b003'
${ noResults }
lightning/plugins/Makefile

119 lines
3.6 KiB
Raw Normal View History

plugins: minimal 'pay' plugin. I wrote this sync first, then rewrote async, then developed libplugin. But committing all that just wastes reviewer time, so I present it as if it was always asnc and using the library helper. Currently the command it registers is 'pay2', but when it's complete we'll remove the internal 'pay' and rename it. This does a single 'getroute/sendpay' call. No retries, no options. Shockingly, this by itself is almost sufficient to pass our current test suite with `pay`->`pay2`. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
PLUGIN_PAY_SRC := plugins/pay.c
PLUGIN_PAY_OBJS := $(PLUGIN_PAY_SRC:.c=.o)
autoclean: make this a plugin. No change in behavior. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
PLUGIN_AUTOCLEAN_SRC := plugins/autoclean.c
PLUGIN_AUTOCLEAN_OBJS := $(PLUGIN_AUTOCLEAN_SRC:.c=.o)
txprepare: a plugin to replace `txprepare` (not yet active). This uses `fundpsbt` and similar to simulate the txprepare command. It has one difference (when complete), in that it those reservations are now timed and don't get reset on restart. It also doesn't have the restriction that `all` can only be used with no other output, as I didn't realize that when I implemented it! Note that change is now inserted in a random position, not sorted into BIP69 order. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4 years ago
PLUGIN_TXPREPARE_SRC := plugins/txprepare.c
PLUGIN_TXPREPARE_OBJS := $(PLUGIN_TXPREPARE_SRC:.c=.o)
plugins/bcli: a new plugin for gathering Bitcoin data Most is taken from lightningd/bitcoind and adapted. This currently exposes 5 commands: - `getchaininfo`, currently called at startup to check the network and whether we are on IBD. - `getrawblockbyheight`, which basically does the `getblockhash` + `getblock` trick. - `getfeerate` - `sendrawtransaction` - `getutxout`, used to gather infos about an output and currently used by `getfilteredblock` in `lightningd/bitcoind`.
5 years ago
PLUGIN_BCLI_SRC := plugins/bcli.c
PLUGIN_BCLI_OBJS := $(PLUGIN_BCLI_SRC:.c=.o)
plugin: Add keysend skeleton
5 years ago
PLUGIN_KEYSEND_SRC := plugins/keysend.c
PLUGIN_KEYSEND_OBJS := $(PLUGIN_KEYSEND_SRC:.c=.o)
plugins/Makefile: Only link in libplugin-pay for plugins that need it. Changelog-None: cleanup only. Before this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1914976 Aug 5 21:54 plugins/bcli ``` After this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1830552 Aug 5 22:00 plugins/bcli ``` We already duplicate a lot of code between `lightningd` and eeach builtin plugin because we do not use .so for `common/`, but including an object file with code that is not referenced in the executable is fairly low-hanging size optimization fruit.
4 years ago
PLUGIN_LIB_SRC := plugins/libplugin.c
PLUGIN_LIB_HEADER := plugins/libplugin.h
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
PLUGIN_LIB_OBJS := $(PLUGIN_LIB_SRC:.c=.o)
plugins/Makefile: Only link in libplugin-pay for plugins that need it. Changelog-None: cleanup only. Before this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1914976 Aug 5 21:54 plugins/bcli ``` After this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1830552 Aug 5 22:00 plugins/bcli ``` We already duplicate a lot of code between `lightningd` and eeach builtin plugin because we do not use .so for `common/`, but including an object file with code that is not referenced in the executable is fairly low-hanging size optimization fruit.
4 years ago
PLUGIN_PAY_LIB_SRC := plugins/libplugin-pay.c
PLUGIN_PAY_LIB_HEADER := plugins/libplugin-pay.h
PLUGIN_PAY_LIB_OBJS := $(PLUGIN_PAY_LIB_SRC:.c=.o)
plugins/spender/: New plugin that will eventually absorb all onchain-spending commands.
4 years ago
PLUGIN_SPENDER_SRC := \
plugins/spender/fundchannel.c: Make fundchannel a thin layer around multifundchannel. Changelog-Changed: protocol: `fundchannel` now shuffles inputs and outputs, and no longer follows BIP69.
4 years ago
plugins/spender/fundchannel.c \
plugins/spender/multiwithdraw.c: Implement multiwithdraw command. Fixes: #2679 Changelog-Added: JSON-RPC: New `multiwithdraw` command to batch multiple onchain sends in a single transaction. Note it shuffles inputs and outputs, does not use BIP69.
4 years ago
plugins/spender/main.c \
plugins/spender/multifundchannel.c: Move multifundchannel to the spenderp plugin.
4 years ago
plugins/spender/multifundchannel.c \
plugins/spender/multiwithdraw.c: Implement multiwithdraw command. Fixes: #2679 Changelog-Added: JSON-RPC: New `multiwithdraw` command to batch multiple onchain sends in a single transaction. Note it shuffles inputs and outputs, does not use BIP69.
4 years ago
plugins/spender/multiwithdraw.c
PLUGIN_SPENDER_HEADER := \
plugins/spender/multifundchannel.c: Move multifundchannel to the spenderp plugin.
4 years ago
plugins/spender/multifundchannel.h \
plugins/spender/fundchannel.c: Make fundchannel a thin layer around multifundchannel. Changelog-Changed: protocol: `fundchannel` now shuffles inputs and outputs, and no longer follows BIP69.
4 years ago
plugins/spender/multiwithdraw.h \
plugins/spender/fundchannel.h \
plugins/spender/multifundchannel.h
plugins/spender/: New plugin that will eventually absorb all onchain-spending commands.
4 years ago
PLUGIN_SPENDER_OBJS := $(PLUGIN_SPENDER_SRC:.c=.o)
plugins/Makefile: Change plugins build procedure. Changelog-None
5 years ago
PLUGIN_ALL_SRC := \
$(PLUGIN_AUTOCLEAN_SRC) \
$(PLUGIN_BCLI_SRC) \
$(PLUGIN_KEYSEND_SRC) \
txprepare: a plugin to replace `txprepare` (not yet active). This uses `fundpsbt` and similar to simulate the txprepare command. It has one difference (when complete), in that it those reservations are now timed and don't get reset on restart. It also doesn't have the restriction that `all` can only be used with no other output, as I didn't realize that when I implemented it! Note that change is now inserted in a random position, not sorted into BIP69 order. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4 years ago
$(PLUGIN_TXPREPARE_SRC) \
plugins/Makefile: Change plugins build procedure. Changelog-None
5 years ago
$(PLUGIN_LIB_SRC) \
plugins/Makefile: Only link in libplugin-pay for plugins that need it. Changelog-None: cleanup only. Before this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1914976 Aug 5 21:54 plugins/bcli ``` After this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1830552 Aug 5 22:00 plugins/bcli ``` We already duplicate a lot of code between `lightningd` and eeach builtin plugin because we do not use .so for `common/`, but including an object file with code that is not referenced in the executable is fairly low-hanging size optimization fruit.
4 years ago
$(PLUGIN_PAY_LIB_SRC) \
plugins/spender/: New plugin that will eventually absorb all onchain-spending commands.
4 years ago
$(PLUGIN_PAY_SRC) \
$(PLUGIN_SPENDER_SRC)
plugins/Makefile: Change plugins build procedure. Changelog-None
5 years ago
PLUGIN_ALL_HEADER := \
plugins/Makefile: Only link in libplugin-pay for plugins that need it. Changelog-None: cleanup only. Before this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1914976 Aug 5 21:54 plugins/bcli ``` After this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1830552 Aug 5 22:00 plugins/bcli ``` We already duplicate a lot of code between `lightningd` and eeach builtin plugin because we do not use .so for `common/`, but including an object file with code that is not referenced in the executable is fairly low-hanging size optimization fruit.
4 years ago
$(PLUGIN_LIB_HEADER) \
plugins/spender/: New plugin that will eventually absorb all onchain-spending commands.
4 years ago
$(PLUGIN_PAY_LIB_HEADER) \
$(PLUGIN_SPENDER_HEADER)
plugins/Makefile: Change plugins build procedure. Changelog-None
5 years ago
PLUGIN_ALL_OBJS := $(PLUGIN_ALL_SRC:.c=.o)
PLUGINS := \
plugins/autoclean \
plugins/bcli \
plugins/keysend \
txprepare: a plugin to replace `txprepare` (not yet active). This uses `fundpsbt` and similar to simulate the txprepare command. It has one difference (when complete), in that it those reservations are now timed and don't get reset on restart. It also doesn't have the restriction that `all` can only be used with no other output, as I didn't realize that when I implemented it! Note that change is now inserted in a random position, not sorted into BIP69 order. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4 years ago
plugins/pay \
plugins/spender/: New plugin that will eventually absorb all onchain-spending commands.
4 years ago
plugins/txprepare \
plugins/spenderp
plugins/Makefile: Change plugins build procedure. Changelog-None
5 years ago
Makefile: normalize all the Makefiles We create ALL_PROGRAMS, ALL_TEST_PROGRAMS, ALL_C_SOURCES and ALL_C_HEADERS. Then the toplevel Makefile knows which are autogenerated (by wildcard), so it can have all the rules to clean them or check the source as necessary. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4 years ago
# Make sure these depend on everything.
ALL_C_SOURCES += $(PLUGIN_ALL_SRC)
ALL_C_HEADERS +=
ALL_PROGRAMS += $(PLUGINS)
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
PLUGIN_COMMON_OBJS := \
addr: handle P2SH/P2PKH in scriptpubkey encoding Previously, returned null if a scriptpubkey was not Segwit; now handles encoding to Base58 for other types.
5 years ago
bitcoin/base58.o \
bitcoin/feerate: new exposure for feerate parsing outside lightningd. This exposes the numeric part of param_feerate() as param_feerate_val(). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
5 years ago
bitcoin/feerate.o \
wire: move remaining bitcoin functions out to bitcoin/ files. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
5 years ago
bitcoin/privkey.o \
psbt: methods to mutate psbt in place add the missing psbt helpers for adding and removing an input and output
5 years ago
bitcoin/psbt.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
bitcoin/pubkey.o \
bitcoin/script.o \
bitcoin/shadouble.o \
bitcoin/short_channel_id.o \
bitcoin/signature.o \
bitcoin/tx.o \
bitcoin/varint.o \
common/json_tok: add param_msat / param_sat. The current param_sat accepts "any": rename and move that to invoice.c where it's called. We rename it to param_msat_or_any and invoice.c is our first (trivial) amount_msat user. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/amount.o \
common: move json_stream helpers to common/json Now that we have json_stream in common/, we can move all the related helpers from lightningd/json to common/json. This way everyone can benefit of them (including libplugin, the plugins themselves, potentially lightning-cli), not lightningd alone! Note that the Makefile of the common/test/ had to be modified, because the new helpers make use of common/wireaddr... Which turns out to \#include <lightingd/lightningd.h> ! So we couldnt just include the .c and add mocks if we redefined some structs (hello run-param).
5 years ago
common/base32.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/bech32.o \
common/bech32_util.o \
wire: use common/bigsize routines Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
5 years ago
common/bigsize.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/bolt11.o \
common/daemon.o \
bolt11: handle `9` fields for new features. This implements https://github.com/lightningnetwork/lightning-rfc/pull/656 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
5 years ago
common/features.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/hash_u5.o \
common/json.o \
plugins/pay: get our own id during init phase. We'll want this for routeboost filtering.
6 years ago
common/json_helpers.o \
common: move json_stream helpers to common/json Now that we have json_stream in common/, we can move all the related helpers from lightningd/json to common/json. This way everyone can benefit of them (including libplugin, the plugins themselves, potentially lightning-cli), not lightningd alone! Note that the Makefile of the common/test/ had to be modified, because the new helpers make use of common/wireaddr... Which turns out to \#include <lightingd/lightningd.h> ! So we couldnt just include the .c and add mocks if we redefined some structs (hello run-param).
5 years ago
common/json_stream.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/json_tok.o \
common/memleak.o \
common/node_id: new type. Node ids are pubkeys, but we only use them as pubkeys for routing and checking gossip messages. So we're packing and unpacking them constantly, and wasting some space and time. This introduces a new type, explicitly the SEC1 compressed encoding (33 bytes). We ensure its validity when we load from the db, or get it from JSON. We still use 'struct pubkey' for peer messages, which checks validity. Results from 5 runs, min-max(mean +/- stddev): store_load_msec,vsz_kb,store_rewrite_sec,listnodes_sec,listchannels_sec,routing_sec,peer_write_all_sec 39475-39572(39518+/-36),2880732,41.150000-41.390000(41.298+/-0.085),2.260000-2.550000(2.336+/-0.11),44.390000-65.150000(58.648+/-7.5),32.740000-33.020000(32.89+/-0.093),44.130000-45.090000(44.566+/-0.32) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/node_id.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/param.o \
plugins/pay: add shadow CLTV calculation. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/pseudorand.o \
common/random_select: central place for reservoir sampling. Turns out we can make quite a simple API out of it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4 years ago
common/random_select.o \
setup: create a common setup which will handle the wally-context Since we now over-write the wally malloc/free functions, we need to do so for tests as well. Here we pull up all of the common setup/teardown logic into a separate place, and update the tests that use libwally to use the new common_setup core Changelog-None
5 years ago
common/setup.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
common/type_to_string.o \
common/utils.o \
common/version.o \
common: move json_stream helpers to common/json Now that we have json_stream in common/, we can move all the related helpers from lightningd/json to common/json. This way everyone can benefit of them (including libplugin, the plugins themselves, potentially lightning-cli), not lightningd alone! Note that the Makefile of the common/test/ had to be modified, because the new helpers make use of common/wireaddr... Which turns out to \#include <lightingd/lightningd.h> ! So we couldnt just include the .c and add mocks if we redefined some structs (hello run-param).
5 years ago
common/wireaddr.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
wire/fromwire.o \
Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES This avoids overwriting the ones in git, and generally makes things neater. We have convenience headers wire/peer_wire.h and wire/onion_wire.h to avoid most #ifdefs: simply include those. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4 years ago
wire/onion$(EXP)_wiregen.o \
paymod: Implement TLV onion payload generation
5 years ago
wire/tlvstream.o \
plugin/libplugin: API for C plugins. Doesn't do logging yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
wire/towire.o
plugins/Makefile: Only link in libplugin-pay for plugins that need it. Changelog-None: cleanup only. Before this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1914976 Aug 5 21:54 plugins/bcli ``` After this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1830552 Aug 5 22:00 plugins/bcli ``` We already duplicate a lot of code between `lightningd` and eeach builtin plugin because we do not use .so for `common/`, but including an object file with code that is not referenced in the executable is fairly low-hanging size optimization fruit.
4 years ago
plugins/pay: bitcoin/chainparams.o $(PLUGIN_PAY_OBJS) $(PLUGIN_LIB_OBJS) $(PLUGIN_PAY_LIB_OBJS) $(PLUGIN_COMMON_OBJS) $(JSMN_OBJS) $(CCAN_OBJS)
$(PLUGIN_PAY_OBJS): $(PLUGIN_PAY_LIB_HEADER)
plugins: minimal 'pay' plugin. I wrote this sync first, then rewrote async, then developed libplugin. But committing all that just wastes reviewer time, so I present it as if it was always asnc and using the library helper. Currently the command it registers is 'pay2', but when it's complete we'll remove the internal 'pay' and rename it. This does a single 'getroute/sendpay' call. No retries, no options. Shockingly, this by itself is almost sufficient to pass our current test suite with `pay`->`pay2`. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
fundchannel: have address work with any network `txprepare` verifies that you're sending to an address on the right network, so this builds a placeholder address for the right network.
5 years ago
plugins/autoclean: bitcoin/chainparams.o $(PLUGIN_AUTOCLEAN_OBJS) $(PLUGIN_LIB_OBJS) $(PLUGIN_COMMON_OBJS) $(JSMN_OBJS) $(CCAN_OBJS)
autoclean: make this a plugin. No change in behavior. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6 years ago
txprepare: a plugin to replace `txprepare` (not yet active). This uses `fundpsbt` and similar to simulate the txprepare command. It has one difference (when complete), in that it those reservations are now timed and don't get reset on restart. It also doesn't have the restriction that `all` can only be used with no other output, as I didn't realize that when I implemented it! Note that change is now inserted in a random position, not sorted into BIP69 order. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4 years ago
plugins/txprepare: bitcoin/chainparams.o $(PLUGIN_TXPREPARE_OBJS) $(PLUGIN_LIB_OBJS) $(PLUGIN_COMMON_OBJS) $(JSMN_OBJS) $(CCAN_OBJS)
plugins/bcli: a new plugin for gathering Bitcoin data Most is taken from lightningd/bitcoind and adapted. This currently exposes 5 commands: - `getchaininfo`, currently called at startup to check the network and whether we are on IBD. - `getrawblockbyheight`, which basically does the `getblockhash` + `getblock` trick. - `getfeerate` - `sendrawtransaction` - `getutxout`, used to gather infos about an output and currently used by `getfilteredblock` in `lightningd/bitcoind`.
5 years ago
plugins/bcli: bitcoin/chainparams.o $(PLUGIN_BCLI_OBJS) $(PLUGIN_LIB_OBJS) $(PLUGIN_COMMON_OBJS) $(JSMN_OBJS) $(CCAN_OBJS)
Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES This avoids overwriting the ones in git, and generally makes things neater. We have convenience headers wire/peer_wire.h and wire/onion_wire.h to avoid most #ifdefs: simply include those. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4 years ago
plugins/keysend: bitcoin/chainparams.o wire/tlvstream.o wire/onion$(EXP)_wiregen.o $(PLUGIN_KEYSEND_OBJS) $(PLUGIN_LIB_OBJS) $(PLUGIN_PAY_LIB_OBJS) $(PLUGIN_COMMON_OBJS) $(JSMN_OBJS) $(CCAN_OBJS)
plugins/Makefile: Only link in libplugin-pay for plugins that need it. Changelog-None: cleanup only. Before this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1914976 Aug 5 21:54 plugins/bcli ``` After this change: ``` $ ls -l plugins/bcli -rwxrwxr-x 1 zmnscpxj zmnscpxj 1830552 Aug 5 22:00 plugins/bcli ``` We already duplicate a lot of code between `lightningd` and eeach builtin plugin because we do not use .so for `common/`, but including an object file with code that is not referenced in the executable is fairly low-hanging size optimization fruit.
4 years ago
$(PLUGIN_KEYSEND_OBJS): $(PLUGIN_PAY_LIB_HEADER)
plugin: Add keysend skeleton
5 years ago
plugins/spender/: New plugin that will eventually absorb all onchain-spending commands.
4 years ago
plugins/spenderp: bitcoin/chainparams.o $(PLUGIN_SPENDER_OBJS) $(PLUGIN_LIB_OBJS) $(PLUGIN_COMMON_OBJS) $(JSMN_OBJS) $(CCAN_OBJS)
plugins/Makefile: Change plugins build procedure. Changelog-None
5 years ago
$(PLUGIN_ALL_OBJS): $(PLUGIN_LIB_HEADER)