lukechilds
/
lightning
mirror of https://github.com/lukechilds/lightning.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
7798 Commits
55 Branches
107 Tags
38 MiB
Tree: aab9893661
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'aab9893661'
${ noResults }
lightning/lightningd/channel_control.h

37 lines
1.2 KiB
Raw Normal View History

lightningd/channel_control: routines to control channeld (move from peer_control.c) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
#ifndef LIGHTNING_LIGHTNINGD_CHANNEL_CONTROL_H
#define LIGHTNING_LIGHTNINGD_CHANNEL_CONTROL_H
#include "config.h"
#include <ccan/short_types/short_types.h>
#include <stdbool.h>
struct channel;
struct crypto_state;
channeld: don&#39;t do explicit state update. We missed it in some corner cases where we crashed/were killed between being told of the lockin and sending the channel_normal_operation message. When we were restarted, we were told both sides were locked in already, so we never updated the state. Pull the entire &#34;tell channeld&#34; logic into channel_control.c, and make it clear that we need to keep waching if we cant&#39;t tell channeld. I think we did get this correct in practice, since funding_announce_cb has the same test, but it&#39;s better to be clear. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
struct lightningd;
common/per_per_state: generalize lightningd/peer_comm Part 1 Encapsulating the peer state was a win for lightningd; not surprisingly, it&#39;s even more of a win for the other daemons, especially as we want to add a little gossip information. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
6 years ago
struct per_peer_state;
lightningd/channel_control: routines to control channeld (move from peer_control.c) Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
lightningd: peer_start_channeld always returns true; make it void. It is always true, and we always ignore it. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
6 years ago
void peer_start_channeld(struct channel *channel,
common/per_per_state: generalize lightningd/peer_comm Part 1 Encapsulating the peer state was a win for lightningd; not surprisingly, it&#39;s even more of a win for the other daemons, especially as we want to add a little gossip information. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
6 years ago
struct per_peer_state *pps,
lightningd/channel_control: routines to control channeld (move from peer_control.c) Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
const u8 *funding_signed,
bool reconnected);
channeld: don&#39;t do explicit state update. We missed it in some corner cases where we crashed/were killed between being told of the lockin and sending the channel_normal_operation message. When we were restarted, we were told both sides were locked in already, so we never updated the state. Pull the entire &#34;tell channeld&#34; logic into channel_control.c, and make it clear that we need to keep waching if we cant&#39;t tell channeld. I think we did get this correct in practice, since funding_announce_cb has the same test, but it&#39;s better to be clear. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
/* Returns true if subd told, otherwise false. */
fix:Add infor about how many blocks needed until funding is confirmed 1. Rename channel_funding_locked to channel_funding_depth in channeld/channel_wire.csv. 2. Add minimum_depth in struct channel in common/initial_channel.h and change corresponding init function: new_initial_channel(). 3. Add confirmation_needed in struct peer in channeld/channeld.c. 4. Rename channel_tell_funding_locked to channel_tell_depth. 5. Call channel_tell_depth even if depth &lt; minimum, and still call lockin_complete in channel_tell_depth, iff depth &gt; minimum_depth. 6. channeld ignore the channel_funding_depth unless its &gt; minimum_depth(except to update billboard, and set peer-&gt;confirmation_needed = minimum_depth - depth).
6 years ago
bool channel_tell_depth(struct lightningd *ld,
channeld: don&#39;t do explicit state update. We missed it in some corner cases where we crashed/were killed between being told of the lockin and sending the channel_normal_operation message. When we were restarted, we were told both sides were locked in already, so we never updated the state. Pull the entire &#34;tell channeld&#34; logic into channel_control.c, and make it clear that we need to keep waching if we cant&#39;t tell channeld. I think we did get this correct in practice, since funding_announce_cb has the same test, but it&#39;s better to be clear. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
struct channel *channel,
channeld: simplify announce/locked-in callback, Just have a &#34;new depth&#34; callback, and let channeld do the right thing. This makes the channeld paths a bit more straightforward. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
const struct bitcoin_txid *txid,
u32 depth);
channel_control: Forget if unconfirmed for a long time and we are fundee. We should forget this as it is a potential DoS if we remember every funding txid that an attacker gave in a `funding_created` but never broadcasted.
7 years ago
/* Notify channels of new blocks. */
void channel_notify_new_block(struct lightningd *ld,
u32 block_height);
channeld: don&#39;t do explicit state update. We missed it in some corner cases where we crashed/were killed between being told of the lockin and sending the channel_normal_operation message. When we were restarted, we were told both sides were locked in already, so we never updated the state. Pull the entire &#34;tell channeld&#34; logic into channel_control.c, and make it clear that we need to keep waching if we cant&#39;t tell channeld. I think we did get this correct in practice, since funding_announce_cb has the same test, but it&#39;s better to be clear. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
API: `fundchannel_cancel` can cancel fundchannel process before funding broadcast
5 years ago
/* Cancel the channel after `fundchannel_complete` succeeds
* but before funding broadcasts. */
struct command_result *cancel_channel_before_broadcast(struct command *cmd,
const char *buffer,
struct peer *peer,
const jsmntok_t *cidtok);
channel control: break out separate method for canceling Break out a method for canceling a channel that will either loop through contacting the peer to tell them of the error or just directly cleans up if the peer is currently disconnected.
5 years ago
/* Forget a channel. Deletes the channel and handles all
* associated waiting commands, if present. Notifies peer if available */
void forget_channel(struct channel *channel, const char *err_msg);
lightningd/channel_control: routines to control channeld (move from peer_control.c) Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
#endif /* LIGHTNING_LIGHTNINGD_CHANNEL_CONTROL_H */