From 0321d79540e4d2ef5296c4717cae390321b3b7d5 Mon Sep 17 00:00:00 2001 From: Rene Pickhardt Date: Wed, 2 Jan 2019 23:16:56 +0100 Subject: [PATCH] [plugin] Improved the example code to encourage usage of optional arguments (#2212) The example code had the `plugin` argument as the last argument. this disallows arguments that have a standard value. As far as I understand the dispatching code the order of arguments does not matter since it is the name `plugin` that is relevant. Therefor I changed the order so that newbe's don't have to read the entire code and can easily add optional arguments --- contrib/plugins/helloworld.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/helloworld.py b/contrib/plugins/helloworld.py index dcc329ca6..3e0e22cb0 100755 --- a/contrib/plugins/helloworld.py +++ b/contrib/plugins/helloworld.py @@ -6,7 +6,7 @@ plugin = Plugin(autopatch=True) @plugin.method("hello") -def hello(name, plugin): +def hello(plugin, name="world"): """This is the documentation string for the hello-function. It gets reported as the description when registering the function @@ -25,12 +25,12 @@ def init(options, configuration, plugin): @plugin.subscribe("connect") -def on_connect(id, address, plugin): +def on_connect(plugin, id, address): plugin.log("Received connect event for peer {}".format(id)) @plugin.subscribe("disconnect") -def on_disconnect(id, plugin): +def on_disconnect(plugin, id): plugin.log("Received disconnect event for peer {}".format(id))