Browse Source

programer -> developer

Signed-off-by: Mark Beckwith <wythe@intrig.com>
ppa-0.6.1
Mark Beckwith 6 years ago
committed by Christian Decker
parent
commit
1851ebbc56
  1. 4
      lightningd/param.c
  2. 12
      lightningd/test/run-param.c

4
lightningd/param.c

@ -284,7 +284,7 @@ static bool param_arr(struct command *cmd, const char *buffer,
{
#if DEVELOPER
if (!check_params(params)) {
command_fail(cmd, PARAM_DEV_ERROR, "programmer error");
command_fail(cmd, PARAM_DEV_ERROR, "developer error");
return false;
}
#endif
@ -312,7 +312,7 @@ bool param(struct command *cmd, const char *buffer,
void *arg = va_arg(ap, void *);
size_t argsize = va_arg(ap, size_t);
if (!param_add(&params, name, required, cb, arg, argsize)) {
command_fail(cmd, PARAM_DEV_ERROR, "programmer error");
command_fail(cmd, PARAM_DEV_ERROR, "developer error");
va_end(ap);
return false;
}

12
lightningd/test/run-param.c

@ -268,33 +268,33 @@ static void bad_programmer(void)
p_req("double", json_tok_double, &dval),
p_req("repeat", json_tok_u64, &ival2), NULL));
assert(check_fail());
assert(strstr(fail_msg, "programmer error"));
assert(strstr(fail_msg, "developer error"));
assert(!param(cmd, j->buffer, j->toks,
p_req("repeat", json_tok_u64, &ival),
p_req("double", json_tok_double, &dval),
p_req("repeat", json_tok_u64, &ival), NULL));
assert(check_fail());
assert(strstr(fail_msg, "programmer error"));
assert(strstr(fail_msg, "developer error"));
assert(!param(cmd, j->buffer, j->toks,
p_req("u64", json_tok_u64, &ival),
p_req("repeat", json_tok_double, &dval),
p_req("repeat", json_tok_double, &dval), NULL));
assert(check_fail());
assert(strstr(fail_msg, "programmer error"));
assert(strstr(fail_msg, "developer error"));
/* check for repeated arguments */
assert(!param(cmd, j->buffer, j->toks,
p_req("u64", json_tok_u64, &ival),
p_req("repeated-arg", json_tok_u64, &ival), NULL));
assert(check_fail());
assert(strstr(fail_msg, "programmer error"));
assert(strstr(fail_msg, "developer error"));
assert(!param(cmd, j->buffer, j->toks,
p_req("u64", (param_cb) NULL, &ival), NULL));
assert(check_fail());
assert(strstr(fail_msg, "programmer error"));
assert(strstr(fail_msg, "developer error"));
/* Add required param after optional */
j = json_parse(cmd, "[ '25', '546', '26', '1.1' ]");
@ -306,7 +306,7 @@ static void bad_programmer(void)
p_opt_def("msatoshi", json_tok_number, &msatoshi, 100),
p_req("riskfactor", json_tok_double, &riskfactor), NULL));
assert(check_fail());
assert(strstr(fail_msg, "programmer error"));
assert(strstr(fail_msg, "developer error"));
}
#endif

Loading…
Cancel
Save