From 1a297a70105beebb9da8000474de02554884371b Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 30 Jan 2018 11:35:26 +1030 Subject: [PATCH] bitcoind: mark request no longer running, even if it fails. We added code to allow a few spurious failures, but it didn't unmark the request running. IRC user 'mlz' (@molxyz) provided logs from his stuck-at-old-block lightningd: lightningd(31981): Adding block 1261159: 00000000da3890ccd0f313a74fccfd4789654b496836da5c28a8d2ad28852264 lightningd(31981): Adding block 1261160: 00000000f70938a33aecbdd7b047cb5cf5b095ea4770c1335acf1859bad1e767 lightningd(31981): bitcoin-cli -testnet estimatesmartfee 2 CONSERVATIVE exited with status 1 Fixes: #749 Signed-off-by: Rusty Russell --- lightningd/bitcoind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lightningd/bitcoind.c b/lightningd/bitcoind.c index 19f55f92d..eba3512d2 100644 --- a/lightningd/bitcoind.c +++ b/lightningd/bitcoind.c @@ -140,7 +140,7 @@ static void bcli_finished(struct io_conn *conn, struct bitcoin_cli *bcli) (int)bcli->output_bytes, bcli->output); bitcoind->error_count++; - + bitcoind->req_running = false; goto done; } } else