From 2e8257e1e6248b94b34e802e4338261fff4ffab1 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Fri, 3 Apr 2020 13:51:27 +1030 Subject: [PATCH] channeld: plug minor leak. We don't free the signatures in this case, and for some reason leak checking on my build machine just found it: MEMLEAK: 0x560f7dc69fc8' label=channeld/gen_channel_wire.c:266:secp256k1_ecdsa_signature' backtrace:' ccan/ccan/tal/tal.c:442 (tal_alloc_)' channeld/gen_channel_wire.c:266 (fromwire_channel_init)' channeld/channeld.c:3060 (init_channel)' channeld/channeld.c:3254 (main)' parents:' channeld/channeld.c:3227:struct peer' MEMLEAK: 0x560f7dc6a288' label=channeld/gen_channel_wire.c:272:secp256k1_ecdsa_signature' backtrace:' ccan/ccan/tal/tal.c:442 (tal_alloc_)' channeld/gen_channel_wire.c:272 (fromwire_channel_init)' channeld/channeld.c:3060 (init_channel)' channeld/channeld.c:3254 (main)' parents:' channeld/channeld.c:3227:struct peer' Signed-off-by: Rusty Russell --- channeld/channeld.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/channeld/channeld.c b/channeld/channeld.c index af19eba09..480dfdb39 100644 --- a/channeld/channeld.c +++ b/channeld/channeld.c @@ -3100,6 +3100,8 @@ static void init_channel(struct peer *peer) * it directly! */ peer->short_channel_ids[REMOTE] = peer->short_channel_ids[LOCAL]; + tal_free(remote_ann_node_sig); + tal_free(remote_ann_bitcoin_sig); } /* First commit is used for opening: if we've sent 0, we're on