From 32a96973a51af1f429270df1b16154187a9af6e0 Mon Sep 17 00:00:00 2001 From: Christian Decker Date: Tue, 12 Dec 2017 22:45:07 +0100 Subject: [PATCH] pytest: Fix a flaky channel_reenable test It was relying on the message order instead of waiting the desired state. Signed-off-by: Christian Decker --- tests/test_lightningd.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_lightningd.py b/tests/test_lightningd.py index 85eed4575..22e4ce90d 100644 --- a/tests/test_lightningd.py +++ b/tests/test_lightningd.py @@ -2366,7 +2366,7 @@ class LightningDTests(BaseLightningDTests): l2.daemon.wait_for_log('Received node_announcement for node {}'.format(l1.info['id'])) # Both directions should be active before the restart - assert [c['active'] for c in l1.rpc.getchannels()['channels']] == [True, True] + wait_for(lambda: [c['active'] for c in l1.rpc.getchannels()['channels']] == [True, True]) # Restart l2, will cause l1 to reconnect l2.stop() @@ -2375,7 +2375,7 @@ class LightningDTests(BaseLightningDTests): # Now they should sync and re-establish again l1.daemon.wait_for_log('Received node_announcement for node {}'.format(l2.info['id'])) l2.daemon.wait_for_log('Received node_announcement for node {}'.format(l1.info['id'])) - assert [c['active'] for c in l1.rpc.getchannels()['channels']] == [True, True] + wait_for(lambda: [c['active'] for c in l1.rpc.getchannels()['channels']] == [True, True]) @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1") def test_update_fee(self):