diff --git a/devtools/gossipwith.c b/devtools/gossipwith.c index 960d1afaf..0bdf44c5c 100644 --- a/devtools/gossipwith.c +++ b/devtools/gossipwith.c @@ -221,7 +221,7 @@ int main(int argc, char *argv[]) "Stream complete gossip history at start"); opt_register_arg("--max-messages", opt_set_ulongval, opt_show_ulongval, &max_messages, - "Terminate after reading this many messages (> 0)"); + "Terminate after reading this many messages"); opt_register_noarg("--stdin", opt_set_bool, &stream_stdin, "Stream gossip messages from stdin."); opt_register_noarg("--no-init", opt_set_bool, &no_init, diff --git a/tests/test_gossip.py b/tests/test_gossip.py index b2fc574cc..a04176304 100644 --- a/tests/test_gossip.py +++ b/tests/test_gossip.py @@ -1123,17 +1123,13 @@ def test_gossip_notices_close(node_factory, bitcoind): wait_for(lambda: l1.rpc.listchannels()['channels'] == []) wait_for(lambda: l1.rpc.listnodes()['nodes'] == []) - # FIXME: This is a hack: we should have a framework for canned conversations - # This doesn't naturally terminate, so we give it 5 seconds. - try: - subprocess.run(['devtools/gossipwith', - '{}@localhost:{}'.format(l1.info['id'], l1.port), - channel_announcement, - channel_update, - node_announcement], - timeout=5, stdout=subprocess.PIPE) - except subprocess.TimeoutExpired: - pass + subprocess.run(['devtools/gossipwith', + '--max-messages=0', + '{}@localhost:{}'.format(l1.info['id'], l1.port), + channel_announcement, + channel_update, + node_announcement], + timeout=TIMEOUT) # l1 should reject it. assert(l1.rpc.listchannels()['channels'] == [])