From 40d34fed9ee89b85fbef1a3be3f50b66a48e2736 Mon Sep 17 00:00:00 2001
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed, 6 Nov 2019 12:46:09 +1030
Subject: [PATCH] pytest: clean up test_gossip_notices_close now that
 gossipwith has more options.

And drive-by fix: document that you can now (since
e40f07803c64686fb80a02ddfc23e24fca0dea48) use --max-messages=0.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 devtools/gossipwith.c |  2 +-
 tests/test_gossip.py  | 18 +++++++-----------
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/devtools/gossipwith.c b/devtools/gossipwith.c
index 960d1afaf..0bdf44c5c 100644
--- a/devtools/gossipwith.c
+++ b/devtools/gossipwith.c
@@ -221,7 +221,7 @@ int main(int argc, char *argv[])
 			   "Stream complete gossip history at start");
 	opt_register_arg("--max-messages", opt_set_ulongval, opt_show_ulongval,
 			 &max_messages,
-			 "Terminate after reading this many messages (> 0)");
+			 "Terminate after reading this many messages");
 	opt_register_noarg("--stdin", opt_set_bool, &stream_stdin,
 			   "Stream gossip messages from stdin.");
 	opt_register_noarg("--no-init", opt_set_bool, &no_init,
diff --git a/tests/test_gossip.py b/tests/test_gossip.py
index b2fc574cc..a04176304 100644
--- a/tests/test_gossip.py
+++ b/tests/test_gossip.py
@@ -1123,17 +1123,13 @@ def test_gossip_notices_close(node_factory, bitcoind):
     wait_for(lambda: l1.rpc.listchannels()['channels'] == [])
     wait_for(lambda: l1.rpc.listnodes()['nodes'] == [])
 
-    # FIXME: This is a hack: we should have a framework for canned conversations
-    # This doesn't naturally terminate, so we give it 5 seconds.
-    try:
-        subprocess.run(['devtools/gossipwith',
-                        '{}@localhost:{}'.format(l1.info['id'], l1.port),
-                        channel_announcement,
-                        channel_update,
-                        node_announcement],
-                       timeout=5, stdout=subprocess.PIPE)
-    except subprocess.TimeoutExpired:
-        pass
+    subprocess.run(['devtools/gossipwith',
+                    '--max-messages=0',
+                    '{}@localhost:{}'.format(l1.info['id'], l1.port),
+                    channel_announcement,
+                    channel_update,
+                    node_announcement],
+                   timeout=TIMEOUT)
 
     # l1 should reject it.
     assert(l1.rpc.listchannels()['channels'] == [])