From 5a8091c853ed9ad6998ccd761765bcc2a742b233 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 24 Jul 2018 15:48:58 +0930 Subject: [PATCH] connectd: cleanup gossip connection properly This still has a problem, but we can't fix that easily here; per-peer daemons don't have this trouble, however. Signed-off-by: Rusty Russell --- connectd/connect.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/connectd/connect.c b/connectd/connect.c index 474e2985c..ae2704bb9 100644 --- a/connectd/connect.c +++ b/connectd/connect.c @@ -632,6 +632,8 @@ static struct io_plan *ready_for_master(struct io_conn *conn, struct peer *peer) peer->gfeatures, peer->lfeatures); + /* FIXME: This can leave half-read/written gossip messages! */ + io_close_taken_fd(peer->local->gossip_conn.conn); send_peer_with_fds(peer, take(msg)); /* In case we set this earlier. */ tal_del_destructor(peer, fail_release);