Browse Source

Feedback from @niftynei.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
plugin-timeout-inc
Rusty Russell 6 years ago
committed by Christian Decker
parent
commit
80753bfbd5
  1. 2
      contrib/pylightning/lightning/lightning.py
  2. 3
      gossipd/routing.c
  3. 2
      lightningd/gossip_control.c
  4. 2
      tests/test_gossip.py

2
contrib/pylightning/lightning/lightning.py

@ -153,7 +153,7 @@ class LightningRpc(UnixDomainSocketRpc):
{cltv} (default 9). If specified search from {fromid} otherwise use {cltv} (default 9). If specified search from {fromid} otherwise use
this node as source. Randomize the route with up to {fuzzpercent} this node as source. Randomize the route with up to {fuzzpercent}
(0.0 -> 100.0, default 5.0) using {seed} as an arbitrary-size string (0.0 -> 100.0, default 5.0) using {seed} as an arbitrary-size string
seed. {exclude} is an optional array of scids[xDirection] to exclude. seed. {exclude} is an optional array of scid/direction to exclude.
""" """
payload = { payload = {
"id": peer_id, "id": peer_id,

3
gossipd/routing.c

@ -489,7 +489,8 @@ find_route(const tal_t *ctx, struct routing_state *rstate,
} }
if (max_hops > ROUTING_MAX_HOPS) { if (max_hops > ROUTING_MAX_HOPS) {
status_info("find_route: max_hops huge amount %zu", max_hops); status_info("find_route: max_hops huge amount %zu > %u",
max_hops, ROUTING_MAX_HOPS);
return NULL; return NULL;
} }

2
lightningd/gossip_control.c

@ -368,7 +368,7 @@ static struct command_result *json_getroute(struct command *cmd,
&excluded_dir[i])) { &excluded_dir[i])) {
return command_fail(cmd, JSONRPC2_INVALID_PARAMS, return command_fail(cmd, JSONRPC2_INVALID_PARAMS,
"%.*s is not a valid" "%.*s is not a valid"
" id+direction", " short_channel_id/direction",
t->end - t->start, t->end - t->start,
buffer + t->start); buffer + t->start);
} }

2
tests/test_gossip.py

@ -284,7 +284,7 @@ def test_gossip_jsonrpc(node_factory):
assert only_one(channels1)['destination'] == l2.info['id'] assert only_one(channels1)['destination'] == l2.info['id']
assert channels1 == channels2 assert channels1 == channels2
channels2 = l2.rpc.listchannels()['channels'] l2.rpc.listchannels()['channels']
# Now proceed to funding-depth and do a full gossip round # Now proceed to funding-depth and do a full gossip round
l1.bitcoin.generate_block(5) l1.bitcoin.generate_block(5)

Loading…
Cancel
Save