rpc: check error now consistent with lightning-cli

We now return JSONRPC2_METHOD_NOT_FOUND if the command is not found,
just like lightning-cli does.

Signed-off-by: Mark Beckwith <wythe@intrig.com>

lightningd/jsonrpc.c

@@ -970,9 +970,9 @@ static bool json_tok_command(struct command *cmd, const char *name,
 	if (cmd->json_cmd)
 		return (*out = tok);
 
-	command_fail(cmd, JSONRPC2_INVALID_PARAMS,
-		     "'%s' of '%.*s' is invalid",
-		     name, tok->end - tok->start, buffer + tok->start);
+	command_fail(cmd, JSONRPC2_METHOD_NOT_FOUND,
+		     "Unknown command '%.*s'",
+		     tok->end - tok->start, buffer + tok->start);
 	return false;
 }
 

tests/test_misc.py

@@ -1079,7 +1079,7 @@ def test_check_command(node_factory):
     l1.rpc.check(command_to_check='help', command='check')
     # Note: this just checks form, not whether it's valid!
     l1.rpc.check(command_to_check='help', command='badcommand')
-    with pytest.raises(RpcError, match=r'is invalid'):
+    with pytest.raises(RpcError, match=r'Unknown command'):
         l1.rpc.check(command_to_check='badcommand')
     with pytest.raises(RpcError, match=r'unknown parameter'):
         l1.rpc.check(command_to_check='help', badarg='x')