channeld: Properly pad and HMAC onion replies that our masterd generated.

7 years ago · 8248dccaee
1 changed files with 9 additions and 3 deletions
--- a/channeld/channel.c
+++ b/channeld/channel.c
@ -2332,10 +2332,16 @@ static void handle_fail(struct peer *peer, const u8 *inmsg)
 							failcode);
 		} else {
 			u8 *reply;
+			u8 *failmsg;
+
+			if (failcode) {
+				failmsg = make_failmsg(inmsg, peer, h,
+						       failcode, &scid);
+				errpkt = create_onionreply(inmsg,
+							   h->shared_secret,
+							   failmsg);
+			}

-			if (failcode)
-				errpkt = make_failmsg(inmsg, peer, h,
-						      failcode, &scid);
 			reply = wrap_onionreply(inmsg, h->shared_secret,
 						errpkt);
 			msg = towire_update_fail_htlc(peer, &peer->channel_id,