Browse Source

bitcoin/tx: remove unused pull_bitcoin_tx_onto.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
ppa-0.6.1
Rusty Russell 7 years ago
committed by Christian Decker
parent
commit
9a6c36a568
  1. 12
      bitcoin/tx.c
  2. 14
      bitcoin/tx.h
  3. 1
      wire/fromwire.c

12
bitcoin/tx.c

@ -381,12 +381,13 @@ static void pull_witness(struct bitcoin_tx_input *inputs, size_t i,
} }
} }
struct bitcoin_tx *pull_bitcoin_tx_onto(const tal_t *ctx, const u8 **cursor, struct bitcoin_tx *pull_bitcoin_tx(const tal_t *ctx, const u8 **cursor,
size_t *max, struct bitcoin_tx *tx) size_t *max)
{ {
size_t i; size_t i;
u64 count; u64 count;
u8 flag = 0; u8 flag = 0;
struct bitcoin_tx *tx = tal(ctx, struct bitcoin_tx);
tx->version = pull_le32(cursor, max); tx->version = pull_le32(cursor, max);
count = pull_length(cursor, max, 32 + 4 + 4 + 1); count = pull_length(cursor, max, 32 + 4 + 4 + 1);
@ -422,13 +423,6 @@ struct bitcoin_tx *pull_bitcoin_tx_onto(const tal_t *ctx, const u8 **cursor,
return tx; return tx;
} }
struct bitcoin_tx *pull_bitcoin_tx(const tal_t *ctx,
const u8 **cursor, size_t *max)
{
struct bitcoin_tx *tx = tal(ctx, struct bitcoin_tx);
return pull_bitcoin_tx_onto(ctx, cursor, max, tx);
}
struct bitcoin_tx *bitcoin_tx_from_hex(const tal_t *ctx, const char *hex, struct bitcoin_tx *bitcoin_tx_from_hex(const tal_t *ctx, const char *hex,
size_t hexlen) size_t hexlen)
{ {

14
bitcoin/tx.h

@ -71,18 +71,4 @@ bool bitcoin_txid_to_hex(const struct bitcoin_txid *txid,
struct bitcoin_tx *pull_bitcoin_tx(const tal_t *ctx, struct bitcoin_tx *pull_bitcoin_tx(const tal_t *ctx,
const u8 **cursor, size_t *max); const u8 **cursor, size_t *max);
/**
* pull_bitcoin_tx_onto - De-serialize a bitcoin tx into tx
*
* Like pull_bitcoin_tx, but skips the allocation of tx. Used by the
* wire implementation where the caller allocates, and the callee only
* fills in values.
*
* @ctx: Allocation context
* @cursor: buffer to read from
* @max: Buffer size left to read
* @tx (out): Destination transaction
*/
struct bitcoin_tx *pull_bitcoin_tx_onto(const tal_t *ctx, const u8 **cursor,
size_t *max, struct bitcoin_tx *tx);
#endif /* LIGHTNING_BITCOIN_TX_H */ #endif /* LIGHTNING_BITCOIN_TX_H */

1
wire/fromwire.c

@ -225,7 +225,6 @@ void derive_channel_id(struct channel_id *channel_id,
channel_id->id[sizeof(*channel_id)-1] ^= txout; channel_id->id[sizeof(*channel_id)-1] ^= txout;
} }
/* FIXME: Simply rename pull_bitcoin_tx, remove pull_bitcoin_tx_onto */
struct bitcoin_tx *fromwire_bitcoin_tx(const tal_t *ctx, struct bitcoin_tx *fromwire_bitcoin_tx(const tal_t *ctx,
const u8 **cursor, size_t *max) const u8 **cursor, size_t *max)
{ {

Loading…
Cancel
Save