Browse Source

JSON: remove fields deprecated in 0.6.2.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
pr-2587
Rusty Russell 6 years ago
committed by neil saitug
parent
commit
aa00e26765
  1. 2
      CHANGELOG.md
  2. 6
      lightningd/gossip_control.c
  3. 6
      lightningd/peer_control.c

2
CHANGELOG.md

@ -26,6 +26,8 @@ changes.
### Removed ### Removed
- JSON RPC: `global_features` and `local_features` fields and `listchannels`' `flags` field. (Deprecated since 0.6.2).
### Fixed ### Fixed
- protocol: reconnection during closing negotiation now supports - protocol: reconnection during closing negotiation now supports

6
lightningd/gossip_control.c

@ -223,9 +223,6 @@ static void json_getnodes_reply(struct subd *gossip UNUSED, const u8 *reply,
nodes[i]->last_timestamp); nodes[i]->last_timestamp);
json_add_hex_talarr(response, "globalfeatures", json_add_hex_talarr(response, "globalfeatures",
nodes[i]->globalfeatures); nodes[i]->globalfeatures);
if (deprecated_apis)
json_add_hex_talarr(response, "global_features",
nodes[i]->globalfeatures);
json_array_start(response, "addresses"); json_array_start(response, "addresses");
for (j=0; j<tal_count(nodes[i]->addresses); j++) { for (j=0; j<tal_count(nodes[i]->addresses); j++) {
json_add_address(response, NULL, &nodes[i]->addresses[j]); json_add_address(response, NULL, &nodes[i]->addresses[j]);
@ -385,9 +382,6 @@ static void json_add_halfchan(struct json_stream *response,
"satoshis", "amount_msat"); "satoshis", "amount_msat");
json_add_num(response, "message_flags", he->message_flags); json_add_num(response, "message_flags", he->message_flags);
json_add_num(response, "channel_flags", he->channel_flags); json_add_num(response, "channel_flags", he->channel_flags);
/* Prior to spec v0891374d47ddffa64c5a2e6ad151247e3d6b7a59, these two were a single u16 field */
if (deprecated_apis)
json_add_num(response, "flags", ((u16)he->message_flags << 8) | he->channel_flags);
json_add_bool(response, "active", json_add_bool(response, "active",
!(he->channel_flags & ROUTING_FLAGS_DISABLED) !(he->channel_flags & ROUTING_FLAGS_DISABLED)
&& !e->local_disabled); && !e->local_disabled);

6
lightningd/peer_control.c

@ -969,12 +969,6 @@ static void json_add_peer(struct lightningd *ld,
struct wireaddr_internal, struct wireaddr_internal,
&p->addr)); &p->addr));
json_array_end(response); json_array_end(response);
if (deprecated_apis) {
json_add_hex_talarr(response, "global_features",
p->globalfeatures);
json_add_hex_talarr(response, "local_features",
p->localfeatures);
}
json_add_hex_talarr(response, "globalfeatures", json_add_hex_talarr(response, "globalfeatures",
p->globalfeatures); p->globalfeatures);
json_add_hex_talarr(response, "localfeatures", json_add_hex_talarr(response, "localfeatures",

Loading…
Cancel
Save