Add shell script linting: Check for shellcheck warnings in shell scripts

Makefile

@@ -263,7 +263,10 @@ check-includes:
 check-cppcheck: .cppcheck-suppress
 	@trap 'rm -f .cppcheck-suppress' 0; git ls-files -- "*.c" "*.h" | grep -vE '^ccan/' | xargs cppcheck -q --language=c --std=c11 --error-exitcode=1 --suppressions-list=.cppcheck-suppress
 
-check-source: check-makefile check-source-bolt check-whitespace check-markdown check-spelling check-python check-includes check-cppcheck
+check-shellcheck:
+	git ls-files -- "*.sh" | xargs shellcheck
+
+check-source: check-makefile check-source-bolt check-whitespace check-markdown check-spelling check-python check-includes check-cppcheck check-shellcheck
 
 full-check: check check-source
 

contrib/Dockerfile.builder

@@ -11,6 +11,7 @@ RUN apt-get -qq update && \
 	automake \
 	clang \
 	cppcheck \
+	shellcheck \
 	eatmydata \
 	software-properties-common \
 	build-essential \

contrib/Dockerfile.builder.i386

@@ -11,6 +11,7 @@ RUN apt-get -qq update && \
 	automake \
 	clang \
 	cppcheck \
+	shellcheck \
 	eatmydata \
 	software-properties-common \
 	build-essential \