From bd655678a6df5d54409771ac4859c7b0ccbd9c2d Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Wed, 17 Apr 2019 06:32:15 +0930 Subject: [PATCH] pytest: fix old code in test, which can cause spurious failures. We generated blocks to announce the channel, but it can also expire the HTLC if the timing is wrong. We don't need to anyway, since we fixed the FIXME; we store local unannounced channels for restoration Signed-off-by: Rusty Russell --- tests/test_pay.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/test_pay.py b/tests/test_pay.py index 8ae79b3fb..b504e2fb3 100644 --- a/tests/test_pay.py +++ b/tests/test_pay.py @@ -278,8 +278,6 @@ def test_payment_success_persistence(node_factory, bitcoind, executor): assert len(payments) == 1 and payments[0]['status'] == 'complete' assert len(invoices) == 1 and invoices[0]['status'] == 'paid' - # FIXME: We should re-add pre-announced routes on startup! - bitcoind.generate_block(5) l1.wait_channel_active(chanid) # A duplicate should succeed immediately (nop) and return correct preimage.