Browse Source
While debugging a hanging channel with a user I noticed that they called `close` on a channel, resulting in the channel showing `CHANNELD_SHUTTING_DOWN`, but the billboard seemed to show the information the wrong way around: ```json { "peers": [ { "connected": true, // ... "channels": [ { "state": "CHANNELD_SHUTTING_DOWN", // ... "status": [ "CHANNELD_SHUTTING_DOWN:Reconnected, and reestablished.", "CHANNELD_SHUTTING_DOWN:Funding transaction locked. They need our announcement signatures. They've sent shutdown, waiting for ours" ], // ... } ] } ] } ``` Aside from the hung channel, the switch in direction of the status seemed weird. Checking the billboard code seems to have the status switched as well:fix-mocksff8830876d/channeld/channeld.c (L223-L226)
We set `shutdown_sent[LOCAL]` when we send the shutdown:ff8830876d/channeld/channeld.c (L823-L839)
And we set `shutdown_sent[REMOTE]` when we receive the shutdown:ff8830876d/channeld/channeld.c (L1730-L1781)
So I think the billboard code just needs to be switched around. Changelog-Fixed: JSON-RPC: The status of the shutdown meesages being exchanged is now displayed correctly.
Christian Decker
4 years ago
committed by
Rusty Russell
1 changed files with 2 additions and 2 deletions
Loading…
Reference in new issue