pytest: test_gossip_jsonrpc can always test aliases.

The whole test is under DEVELOPER anyway, but even if it weren't it
would work fine.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

tests/test_lightningd.py

@@ -2455,16 +2455,14 @@ class LightningDTests(BaseLightningDTests):
         assert n2['nodeid'] == l2.info['id']
 
         # Might not have seen other node-announce yet.
-        # TODO(cdecker) Can't check these without DEVELOPER=1, re-enable after we get alias and color into getinfo
+        assert n1['alias'].startswith('JUNIORBEAM')
-        if DEVELOPER:
+        assert n1['color'] == '0266e4'
-            assert n1['alias'].startswith('JUNIORBEAM')
+        if 'alias' not in n2:
-            assert n1['color'] == '0266e4'
+            assert 'color' not in n2
-            if 'alias' not in n2:
+            assert 'addresses' not in n2
-                assert 'color' not in n2
+        else:
-                assert 'addresses' not in n2
+            assert n2['alias'].startswith('SILENTARTIST')
-            else:
+            assert n2['color'] == '022d22'
-                assert n2['alias'].startswith('SILENTARTIST')
-                assert n2['color'] == '022d22'
 
         assert [c['active'] for c in l1.rpc.listchannels()['channels']] == [True, True]
         assert [c['public'] for c in l1.rpc.listchannels()['channels']] == [True, True]