lightning

6606 Commits

55 Branches

107 Tags

38 MiB

Tree: 32a1b782f3

Commit Graph

Author	SHA1	Message	Date
Rusty Russell	fed5a117e7	Update ccan/structeq. structeq() is too dangerous: if a structure has padding, it can fail silently. The new ccan/structeq instead provides a macro to define foo_eq(), which does the right thing in case of padding (which none of our structures currently have anyway). Upgrade ccan, and use it everywhere. Except run-peer-wire.c, which is only testing code and can use raw memcmp(): valgrind will tell us if padding exists. Interestingly, we still declared short_channel_id_eq, even though we didn't define it any more! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago
Rusty Russell	c6997f15c7	bitcoin/preimage: struct preimage. We had a hack for 'struct rval' in protobuf_convert.h; make an explicit header and put it in bitcoin/preimage.h. It's not really bitcoin-specific, but it's better than having bitcoin/script depend on an external header. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	8 years ago

Author

SHA1

Message

Date

Rusty Russell

fed5a117e7

Update ccan/structeq.

structeq() is too dangerous: if a structure has padding, it can fail
silently.

The new ccan/structeq instead provides a macro to define foo_eq(),
which does the right thing in case of padding (which none of our
structures currently have anyway).

Upgrade ccan, and use it everywhere.  Except run-peer-wire.c, which
is only testing code and can use raw memcmp(): valgrind will tell us
if padding exists.

Interestingly, we still declared short_channel_id_eq, even though
we didn't define it any more!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7 years ago

Rusty Russell

c6997f15c7

bitcoin/preimage: struct preimage.

We had a hack for 'struct rval' in protobuf_convert.h; make an
explicit header and put it in bitcoin/preimage.h.  It's not really
bitcoin-specific, but it's better than having bitcoin/script depend on
an external header.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

8 years ago

2 Commits (32a1b782f3121e31d4af25aeb2ee5917c55fffca)