lightning

6323 Commits

55 Branches

107 Tags

38 MiB

Tree: 3f1ca18f2f

Commit Graph

Author	SHA1	Message	Date
Simon Vrouwe	5b5d70d640	lightningd/plugin: extend plugins->startup window to include plugins_config Fixes incorrect configuration[`startup`] in plugin `init`, modified tests to test this.	6 years ago
Christian Decker	9d4148ce68	pylightning: Warn users of plugins that may break due to extra args We recently noticed that the way we unpack the call arguments for hooks and notifications in pylightning breaks pretty quickly once you start changing the hook and notification params. If you add params they will not get mapped correctly causing the plugin to error out. This can be fixed by adding a `VAR_KEYWORD` argument to the calbacks, i.e., by adding a single `**kwargs` argument at the end of the signature. This commit adds a check that such a catch-all argument exists, and emits a warning if it doesn't. It also fixes up the plugins that we ship ourselves. Signed-off-by: Christian Decker <decker.christian@gmail.com>	6 years ago
Rusty Russell	7ccf3af51d	pytest: test the db hook plugin. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	6 years ago

Author

SHA1

Message

Date

Simon Vrouwe

5b5d70d640

lightningd/plugin: extend plugins->startup window to include plugins_config

Fixes incorrect configuration[`startup`] in plugin `init`, modified tests
to test this.

6 years ago

Christian Decker

9d4148ce68

pylightning: Warn users of plugins that may break due to extra args

We recently noticed that the way we unpack the call arguments for hooks and
notifications in pylightning breaks pretty quickly once you start changing the
hook and notification params. If you add params they will not get mapped
correctly causing the plugin to error out.

This can be fixed by adding a `VAR_KEYWORD` argument to the calbacks, i.e., by
adding a single `**kwargs` argument at the end of the signature. This commit
adds a check that such a catch-all argument exists, and emits a warning if it
doesn't.

It also fixes up the plugins that we ship ourselves.

Signed-off-by: Christian Decker <decker.christian@gmail.com>

6 years ago

Rusty Russell

7ccf3af51d

pytest: test the db hook plugin.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

6 years ago

3 Commits (3f1ca18f2f9ea4bf4ff94d66b14e4dbbe5f771dc)