Rusty Russell
666e1b320f
lightningd: fix double-specified args.
We need to make sure the arg is a tal object, as we'll free it next time.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
practicalswift
abf510740d
Force the use of the POSIX C locale for all commands and their subprocesses
7 years ago
practicalswift
6269a4c55d
Remove unused functions not covered by unit tests
7 years ago
Rusty Russell
7ae013202f
json: make json_add_string do partial escapes.
This is useful when we log a JSON-escaped string, so we don't double-escape.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
practicalswift
98f49c0837
Remove include in file foo.c that is already included in foo.h
7 years ago
Mark Beckwith
38e94e883f
Improved display of lightning-cli help for humans
The display format is now:
command1
description1
command2
description2
.
.
.
7 years ago
ZmnSCPxj
cabeef2d88
lightning-cli: Be more discerning about literals.
Fixes : #574
The issue states that we should follow the standard when
parsing the port for IPv6 [addr]:port syntax, but this is
actually already supported by the daemon. The issue arises
due to the `lightning-cli` misinterpreting [addr]:port as
an array. This modification makes [addr]:port interpreted
as a string.
7 years ago
practicalswift
91a9c2923f
Mark intentionally unused parameters as such (with "UNUSED")
7 years ago
Rusty Russell
8be1c1df32
Updates for changed external/jsmn API change.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
Rusty Russell
c3bd78433f
lightning-cli: keyword mode.
By default, autodetect, but that's unreliable, so use -k/-o to force
interpretation.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
Rusty Russell
7d18ef9ecf
lightning-cli: human-readable printing for help.
And make it an option for now for other commands; consider making
it the default.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
practicalswift
2c17546cbd
Onboarding: Make "lightning-cli" (without arguments) output the equivalent of "lightning-cli --help; lightning-cli help"
New users invoking lightning-cli are likely interested in what RPC
commands they can invoke via the command.
7 years ago
ZmnSCPxj
940819567d
lightning-cli: Add support for null argument.
7 years ago
Rusty Russell
1bd40a8da6
lightning-cli: make valgrind happy by freeing opt table.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
Rusty Russell
aa34ad30d9
lighting-cli: do incremental parsing.
Far less hacky, and a little faster:
real 0m0.168s
user 0m0.135s
sys 0m0.033s
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
Rusty Russell
61cff03465
lightning-cli: test for amazingly slow getlogs speed.
real 3m51.167s
user 3m51.065s
sys 0m0.080s
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
renepickhardt
69260adb38
quickfixing issue #662 to make CLI more userfriendly for inexperienced users ( #663 )
* making the cli more user friendly for inexperienced users #662
providing a quickfix for https://github.com/ElementsProject/lightning/issues/662
Basically I extended the ./lighting-cli --help message to at least state that one should use ./lighting-cli help, and added a hint to cli/lighting-cli help to the README
Closes : #662
7 years ago
Rusty Russell
739b163f8b
Makefiles: simplify dependencies.
Gather all binaries and objects and make the depend on external
requirements and common headers.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
Rusty Russell
f42f34b82d
external: new subdirectory for all external libraries and submodules.
You will want to 'make distclean' after this.
I also removed libsecp; we use the one in in libwally anyway.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
Rusty Russell
a37c165cb9
common: move some files out of lightningd/
Basically all files shared by different daemons.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
Rusty Russell
8375857116
common: absorb remaining files from daemon/
Also, we split the more sophisticated json_add helpers to avoid pulling in
everything into lightning-cli, and unify the routines to print struct
short_channel_id (it's ':', not '/' too).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago