lightning

3617 Commits

55 Branches

107 Tags

38 MiB

Tree: 78a074af5a

Commit Graph

Author	SHA1	Message	Date
ZmnSCPxj, ZmnSCPxj jxPCSmnZ	044705a547	peer_control: Fix a use-after-free bug. (#1237 ) This bug is a classic case of being lazy: 1. peer_accept_channel() allocated its return off the input message, rather than taking an explicit allocation context. This concealed the lifetime nature of the return. 2. The context for sanitize_error was the error itself, rather than the more obvious tmpctx (connect_failed does not take). The global tmpctx removes the "efficiency" excuse for grabbing a random object to use as context, and is also nice and explicit. All-the-hard-work-by: @ZmnSCPxj	7 years ago
Rusty Russell	4cf274b1c0	lightningd/opening_control: routines to control openingd (move from peer_control.c) We also fold opening_got_hsm_funding_sig() into the caller; it was previously a callback before we decided to always use the HSM synchronously. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago

Author

SHA1

Message

Date

ZmnSCPxj, ZmnSCPxj jxPCSmnZ

044705a547

peer_control: Fix a use-after-free bug. (#1237 )

This bug is a classic case of being lazy:
1. peer_accept_channel() allocated its return off the input message,
   rather than taking an explicit allocation context.  This concealed the
   lifetime nature of the return.
2. The context for sanitize_error was the error itself, rather than the
   more obvious tmpctx (connect_failed does not take).

The global tmpctx removes the "efficiency" excuse for grabbing a random
object to use as context, and is also nice and explicit.

All-the-hard-work-by: @ZmnSCPxj

7 years ago

Rusty Russell

4cf274b1c0

lightningd/opening_control: routines to control openingd (move from peer_control.c)

We also fold opening_got_hsm_funding_sig() into the caller; it was
previously a callback before we decided to always use the HSM
synchronously.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7 years ago

2 Commits (78a074af5acfeb60fc5d58ae083ef4bec48801a7)