lightning

1400 Commits

55 Branches

107 Tags

38 MiB

Tree: 8a893df951

Commit Graph

Author	SHA1	Message	Date
Rusty Russell	8a893df951	lightningd/subd: fix use-after-free, cleanup subd_send_msg unnecessary tal_dup. subd_req() needs to get the type before it calls subd_send_msg, because if it's take() then msg_enqueue() may reallocate. Which also made me realize that subd_send_message() should not try to dup, since msg_enqueue() handles that itself. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	8 years ago
Christian Decker	8ae698d1dc	Migrating daemon_conn to msg_queue and msg_queue takes over messages We have some duplication in handling queues, so this is an attempt at deduplicating some of that work. `daemon_conn` now uses the `msg_queue` and `channeld` was also migrated to `msg_queue`. At the same time I made `msg_queue` create a copy of the messages or takes over messages marked with `take()`. This should make cleaning up messages easier.	8 years ago
Rusty Russell	95f41287f0	lightningd/subd: new code for subdaemons. This uses a single fd for both status and control. To make this work, we enforce the convention that replies are the same as requests + 100, and that their name ends in "_REPLY". This also means that various daemons can simply exit when done; there's no race between reading request and closing status fds. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	8 years ago

Author

SHA1

Message

Date

Rusty Russell

8a893df951

lightningd/subd: fix use-after-free, cleanup subd_send_msg unnecessary tal_dup.

subd_req() needs to get the type before it calls subd_send_msg, because
if it's take() then msg_enqueue() may reallocate.

Which also made me realize that subd_send_message() should not try to dup,
since msg_enqueue() handles that itself.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

8 years ago

Christian Decker

8ae698d1dc

Migrating daemon_conn to msg_queue and msg_queue takes over messages

We have some duplication in handling queues, so this is an attempt at
deduplicating some of that work. `daemon_conn` now uses the
`msg_queue` and `channeld` was also migrated to `msg_queue`. At the
same time I made `msg_queue` create a copy of the messages or takes
over messages marked with `take()`. This should make cleaning up
messages easier.

8 years ago

Rusty Russell

95f41287f0

lightningd/subd: new code for subdaemons.

This uses a single fd for both status and control.

To make this work, we enforce the convention that replies are the same
as requests + 100, and that their name ends in "_REPLY".

This also means that various daemons can simply exit when done; there's
no race between reading request and closing status fds.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

8 years ago

3 Commits (8a893df951ccfb23b194e6f511c9a1bca0d95701)