lightning

3628 Commits

55 Branches

107 Tags

38 MiB

Tree: 8e976150ad

Commit Graph

Author	SHA1	Message	Date
Rusty Russell	8e976150ad	json_fundchannel: fix release vs connect/nongossip race. The new connect code revealed an existing race: we tell gossipd to release the peer, but at the same time it connects in. gossipd fails the release because the peer is remote, and json_fundchannel fails. Instead, we catch this race when we get peer_connected() and we were trying to open a channel. It means keeping a list of fundchannels which are awaiting a gossipd response though. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago
ZmnSCPxj, ZmnSCPxj jxPCSmnZ	044705a547	peer_control: Fix a use-after-free bug. (#1237 ) This bug is a classic case of being lazy: 1. peer_accept_channel() allocated its return off the input message, rather than taking an explicit allocation context. This concealed the lifetime nature of the return. 2. The context for sanitize_error was the error itself, rather than the more obvious tmpctx (connect_failed does not take). The global tmpctx removes the "efficiency" excuse for grabbing a random object to use as context, and is also nice and explicit. All-the-hard-work-by: @ZmnSCPxj	7 years ago
Rusty Russell	4cf274b1c0	lightningd/opening_control: routines to control openingd (move from peer_control.c) We also fold opening_got_hsm_funding_sig() into the caller; it was previously a callback before we decided to always use the HSM synchronously. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago

Author

SHA1

Message

Date

Rusty Russell

8e976150ad

json_fundchannel: fix release vs connect/nongossip race.

The new connect code revealed an existing race: we tell gossipd to
release the peer, but at the same time it connects in.  gossipd fails
the release because the peer is remote, and json_fundchannel fails.

Instead, we catch this race when we get peer_connected() and we were
trying to open a channel.  It means keeping a list of fundchannels which
are awaiting a gossipd response though.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7 years ago

ZmnSCPxj, ZmnSCPxj jxPCSmnZ

044705a547

peer_control: Fix a use-after-free bug. (#1237 )

This bug is a classic case of being lazy:
1. peer_accept_channel() allocated its return off the input message,
   rather than taking an explicit allocation context.  This concealed the
   lifetime nature of the return.
2. The context for sanitize_error was the error itself, rather than the
   more obvious tmpctx (connect_failed does not take).

The global tmpctx removes the "efficiency" excuse for grabbing a random
object to use as context, and is also nice and explicit.

All-the-hard-work-by: @ZmnSCPxj

7 years ago

Rusty Russell

4cf274b1c0

lightningd/opening_control: routines to control openingd (move from peer_control.c)

We also fold opening_got_hsm_funding_sig() into the caller; it was
previously a callback before we decided to always use the HSM
synchronously.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7 years ago

3 Commits (8e976150adb4c98cdb3aee2a31db21e9489a3e66)