lightning

6287 Commits

55 Branches

107 Tags

38 MiB

Tree: 8eddbb4561

Commit Graph

Author	SHA1	Message	Date
Christian Decker	9d4148ce68	pylightning: Warn users of plugins that may break due to extra args We recently noticed that the way we unpack the call arguments for hooks and notifications in pylightning breaks pretty quickly once you start changing the hook and notification params. If you add params they will not get mapped correctly causing the plugin to error out. This can be fixed by adding a `VAR_KEYWORD` argument to the calbacks, i.e., by adding a single `**kwargs` argument at the end of the signature. This commit adds a check that such a catch-all argument exists, and emits a warning if it doesn't. It also fixes up the plugins that we ship ourselves. Signed-off-by: Christian Decker <decker.christian@gmail.com>	6 years ago
Christian Decker	53488e5739	pytest: Strengthen the htlc_accepted tests We were having a few issues with malformed data in the past, so this time we really check that stuff. Signed-off-by: Christian Decker <decker.christian@gmail.com>	6 years ago
Christian Decker	dd26a01c54	pytest: Add a test for htlc_accepted hook replay on startup	6 years ago

Author

SHA1

Message

Date

Christian Decker

9d4148ce68

pylightning: Warn users of plugins that may break due to extra args

We recently noticed that the way we unpack the call arguments for hooks and
notifications in pylightning breaks pretty quickly once you start changing the
hook and notification params. If you add params they will not get mapped
correctly causing the plugin to error out.

This can be fixed by adding a `VAR_KEYWORD` argument to the calbacks, i.e., by
adding a single `**kwargs` argument at the end of the signature. This commit
adds a check that such a catch-all argument exists, and emits a warning if it
doesn't.

It also fixes up the plugins that we ship ourselves.

Signed-off-by: Christian Decker <decker.christian@gmail.com>

6 years ago

Christian Decker

53488e5739

pytest: Strengthen the htlc_accepted tests

We were having a few issues with malformed data in the past, so this time we
really check that stuff.

Signed-off-by: Christian Decker <decker.christian@gmail.com>

6 years ago

Christian Decker

dd26a01c54

pytest: Add a test for htlc_accepted hook replay on startup

6 years ago

3 Commits (8eddbb4561b864779c4b9f08ba8b29e9fe8b18a6)