1da27c51c2
gossip: Remove annoying nonlocal_gossip_broadcast_done status
Reported-by: @RvMP
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
a7a6b4646a
json-rpc: Remove alarming debug statement
People keep on stumbling over this, since it's rather alarming.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
3d2ef44064
gossipd: Do not report bind failures for IPv4
7 years ago
8bf9f28a79
doc: Specify that pruned nodes do not work currently
7 years ago
45c935ddba
pytest: Have the db_query helper work on a copy of the DB
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
24ba5d6250
channeld: don't spam with all our attempts to commit.
Reported-by: @jb55
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
8e087c1d71
clarified lightning-cli help dev-setfees description
7 years ago
fa992ecaab
clarified --lightning-dir syntax on help
7 years ago
5b4a62d822
doc: some sqlite db info for HACKING
Signed-off-by: William Casarin <jb55@jb55.com>
7 years ago
6cfc0a6275
fixup! masterd: Disable a channel when channeld fails
7 years ago
2e5047f74b
pytest: Fix test_pay_disconnect
We are now too quick in disabling the channel for us to attempt a
payment. We need to separate into getroute and sendpay to trigger this
now.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
dafd000c2a
pytest: Check that we disable on closing and permfail.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
e463386d75
masterd: Disable a channel when channeld fails
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
007c349dec
gossip: Implement handler for enabling and disabling channels
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
c6ae4b521f
gossip: Add message to enable and disable a channel
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
d14969ce77
masterd: Peer has to know which direction an eventual channel is
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
4f4b0e9bba
channeld: Tell gossipd when we get a shutdown message from a peer
Disabling the channel and enqueing the update for broadcast so we
don't get forwarding requests from remote peers, and we don't try to
ourselves.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
6320142c34
channeld: Send disabling channel_update on shutdown
Sends a disable channel_update before issuing the shutdown message,
gossipd will also take care to update others and not use for future
routes.
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
8aee38162c
doc: Nix{,OS} build instructions
Signed-off-by: William Casarin <jb55@jb55.com>
7 years ago
17aaa1d235
Fix lightning typos
7 years ago
3e40a48332
Add lightning spell check
7 years ago
2c17546cbd
Onboarding: Make "lightning-cli" (without arguments) output the equivalent of "lightning-cli --help; lightning-cli help"
New users invoking lightning-cli are likely interested in what RPC
commands they can invoke via the command.
7 years ago
bab3b1a16b
wallet: get first blocknum from any channels.
The previous tests didn't make sense anyway, but I think they were trying
to exclude onchain channels.
We delete completely forgotten channels anyway now, so we don't need
such testing.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
661950e402
wallet: fix logic for finding first block.
Over 20 years a professional C programmer, still can't count from zero!
Fixes : #709
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
e66bd25b5c
test_lightningd.py: test lockin while we're not running.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
9f9c34002e
chain_topology: log block height, not just hash.
Saves me a lookup.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
e9328217ff
peer_control: better logging when we don't tell peer about locked funding.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
c42fa4404a
connect: succeed if we connect to peer and it *doesn't* go back to gossipd.
The JSON connect command wouldn't terminate if peer reconnected
in a state CHANNELD_AWAITING_LOCKIN or above.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
b91556283b
Onboarding: Adjust log level for common non-fatal peer state condition from info to debug
7 years ago
3a8220d630
Warn instead of crash when extract_feerate(...) fails
Fixes : #722
7 years ago
0557467dfa
Adjust log level for feerate warnings
This condition seems to be triggered quite common on testnet, so no
need for warning floods unless we're running in debug mode :-)
7 years ago
7b0d806d71
pytest: Check that we forget irrevocably settled channels
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
9588c961bb
wallet: Forget channels that are irrevocably settled on-chain
Signed-off-by: Christian Decker <decker.christian@gmail.com>
7 years ago
f03dbde354
test_lightningd.py: Test 0-msatoshi pay
Based-on-patch-by: ZmnSCPxj <ZmnSCPxj@protonmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
45665a994b
htlc_end: allow htlc_out to have 0 msatoshi.
Such an htlc is invalid, and will be failed cleanly by our channeld
(which also checks that it meets the minimum amount), but it's
not the master's job to check it, and in fact, it asserts if we were
to try to pay or forward such a thing.
Fixes : #686
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
3ccf88d6c4
lightningd: check channeld isn't trying to add 0-satoshi incoming HTLCs.
The peer shouldn't try, and channeld won't try to add it if it does,
but we shouldn't trust it. And it would make our htlc_in_check() code
assert.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
3cb03ab784
bitcoin: add test programs to ALL_TEST_PROGRAMS
* Add BITCOIN_TEST_PROGRAMS to ALL_TEST_PROGRAMS
* Refactor bitcoin test make directives into its own Makefile under bitcoin/test
Signed-off-by: William Casarin <jb55@jb55.com>
7 years ago
5421e9f6f2
pylightning: Add and move example to README
7 years ago
96d093fb30
Fix typos
7 years ago
feb734086b
build: Update INSTALL.md to include FreeBSD.
7 years ago
f55adbdc9c
build: Add necessary build/link flags for FreeBSD.
7 years ago
8da65854f0
build: Add needed UNIX standard includes.
7 years ago
75f4b56766
build: Correctly build and link ptr_valid.
7 years ago
2f4ba73c77
Allocate hex buffer on heap since it can be very large.
7 years ago
5631054152
Start all command descriptions with a verb ("Show", "Set", etc.). Remove unused help texts.
7 years ago
940819567d
lightning-cli: Add support for null argument.
7 years ago
22087dad03
Adjust log level: Warn about ignored fee limits only in debug log
7 years ago
1bd40a8da6
lightning-cli: make valgrind happy by freeing opt table.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
aa34ad30d9
lighting-cli: do incremental parsing.
Far less hacky, and a little faster:
real 0m0.168s
user 0m0.135s
sys 0m0.033s
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
2ff9e42b33
lightning-cli: fix amazingly slow getlogs speed.
real 0m0.380s
user 0m0.331s
sys 0m0.028s
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
Christian Decker
Rusty Russell
Ronald van der Meer
William Casarin
practicalswift
alaniz
Carl Dong
Carl Dong
Björge Dijkstra
ZmnSCPxj