lightning

4420 Commits

55 Branches

107 Tags

38 MiB

Tree: a475098928

Commit Graph

Author	SHA1	Message	Date
William Casarin	f8fa4213f1	tools: use /usr/bin/env bash instead of /bin/bash These commands fail on systems that do not have bash under /bin Signed-off-by: William Casarin <jb55@jb55.com>	7 years ago
Jan Sarenik	9f519afc5d	tools/check-includes.sh: shellcheck recommended fixes $ shellcheck --version ShellCheck - shell script analysis tool version: 0.5.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net $ make check-source ... In tools/check-includes.sh line 14: if [[ $(grep -cE "^#((ifndef\|define) ${HEADER_ID}\|endif /\* ${HEADER_ID} \/)$" "${HEADER_FILE}") != 3 ]]; then ^-- SC1117: Backslash is literal in "\". Prefer explicit escaping: "\\*". In tools/check-includes.sh line 28: git ls-files \| grep -v 'ccan/' \| grep -E "\.${1}"'$' ^-- SC1117: Backslash is literal in "\.". Prefer explicit escaping: "\\.".	7 years ago
practicalswift	e078fcefdd	Add check-includes.sh: Find redundant includes. Check ifndef:s.	7 years ago

Author

SHA1

Message

Date

William Casarin

f8fa4213f1

tools: use /usr/bin/env bash instead of /bin/bash

These commands fail on systems that do not have bash under /bin

Signed-off-by: William Casarin <jb55@jb55.com>

7 years ago

Jan Sarenik

9f519afc5d

tools/check-includes.sh: shellcheck recommended fixes

$ shellcheck --version
    ShellCheck - shell script analysis tool
    version: 0.5.0
    license: GNU General Public License, version 3
    website: https://www.shellcheck.net
    $ make check-source
    ...

    In tools/check-includes.sh line 14:
        if [[ $(grep -cE "^#((ifndef|define) ${HEADER_ID}|endif /\* ${HEADER_ID} \*/)$" "${HEADER_FILE}") != 3 ]]; then
                                                                 ^-- SC1117: Backslash is literal in "\*". Prefer explicit escaping: "\\*".

    In tools/check-includes.sh line 28:
        git ls-files | grep -v 'ccan/' | grep -E "\.${1}"'$'
                                                  ^-- SC1117: Backslash is literal in "\.". Prefer explicit escaping: "\\.".

7 years ago

practicalswift

e078fcefdd

Add check-includes.sh: Find redundant includes. Check ifndef:s.

7 years ago

3 Commits (a475098928e1b6c018986704937cbab9f1f017d9)