lightning

6200 Commits

55 Branches

107 Tags

38 MiB

Tree: af0200f9d0

Commit Graph

Author	SHA1	Message	Date
Christian Decker	9d4148ce68	pylightning: Warn users of plugins that may break due to extra args We recently noticed that the way we unpack the call arguments for hooks and notifications in pylightning breaks pretty quickly once you start changing the hook and notification params. If you add params they will not get mapped correctly causing the plugin to error out. This can be fixed by adding a `VAR_KEYWORD` argument to the calbacks, i.e., by adding a single `**kwargs` argument at the end of the signature. This commit adds a check that such a catch-all argument exists, and emits a warning if it doesn't. It also fixes up the plugins that we ship ourselves. Signed-off-by: Christian Decker <decker.christian@gmail.com>	6 years ago
Rusty Russell	ca7864f2f3	invoice_hook: remove nested result. I misunderstood the API, this ended up nesting a result inside the JSON-RPC result. No concerns about backwards compatibility since this is so new. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	6 years ago
Rusty Russell	9c373fecb6	pytest: test the invoice hook. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	6 years ago

Author

SHA1

Message

Date

Christian Decker

9d4148ce68

pylightning: Warn users of plugins that may break due to extra args

We recently noticed that the way we unpack the call arguments for hooks and
notifications in pylightning breaks pretty quickly once you start changing the
hook and notification params. If you add params they will not get mapped
correctly causing the plugin to error out.

This can be fixed by adding a `VAR_KEYWORD` argument to the calbacks, i.e., by
adding a single `**kwargs` argument at the end of the signature. This commit
adds a check that such a catch-all argument exists, and emits a warning if it
doesn't.

It also fixes up the plugins that we ship ourselves.

Signed-off-by: Christian Decker <decker.christian@gmail.com>

6 years ago

Rusty Russell

ca7864f2f3

invoice_hook: remove nested result.

I misunderstood the API, this ended up nesting a result inside the JSON-RPC
result.

No concerns about backwards compatibility since this is so new.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

6 years ago

Rusty Russell

9c373fecb6

pytest: test the invoice hook.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

6 years ago

3 Commits (af0200f9d0dd9eb6bec8089892bb1e79ee7268dc)