lightning

3194 Commits

55 Branches

107 Tags

38 MiB

Tree: bd07a91782

Commit Graph

Author	SHA1	Message	Date
Rusty Russell	eb0603bd13	wireaddr: rework port parsing for weird addresses. We save wireaddr to databases as a string (which is pretty dumb) but it turned out that my local node saved '[::ffff:127.0.0.1]:49150' which our parser can't parse. Thus I've reworked the parser to make fewer assumptions: parse_ip_port() is renamed to separate_address_and_port() and is now far more accepting of different forms, and returns failure only on grossly malformed strings. Otherwise it overwrites its *port arg only if there's a port specified. I also made it static. Then fromwire_wireaddr() hands the resulting address to inet_pton to figure out if it's actually valid. Cc: William Casarin <jb55@jb55.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago
William Casarin	ce1d709d44	wireaddr: fix ipv6 formatting with ports in fmt_wireaddr Correctly format ipv6 address with ports. This will also make it more compatible with the new parse_wireaddr, which has been updated to parse ports. They are inverses now. Also add some tests that check this. Signed-off-by: William Casarin <jb55@jb55.com>	7 years ago
William Casarin	3e7aabe256	test: add tests for parse_ip_port This tests the basic functionality of parse_ip_port, which is used in parse_wireaddr. Signed-off-by: William Casarin <jb55@jb55.com>	7 years ago

Author

SHA1

Message

Date

Rusty Russell

eb0603bd13

wireaddr: rework port parsing for weird addresses.

We save wireaddr to databases as a string (which is pretty dumb) but
it turned out that my local node saved '[::ffff:127.0.0.1]:49150'
which our parser can't parse.

Thus I've reworked the parser to make fewer assumptions:
parse_ip_port() is renamed to separate_address_and_port() and is now
far more accepting of different forms, and returns failure only on
grossly malformed strings.  Otherwise it overwrites its *port arg only
if there's a port specified.  I also made it static.

Then fromwire_wireaddr() hands the resulting address to inet_pton to
figure out if it's actually valid.

Cc: William Casarin <jb55@jb55.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7 years ago

William Casarin

ce1d709d44

wireaddr: fix ipv6 formatting with ports in fmt_wireaddr

Correctly format ipv6 address with ports. This will also make it more compatible
with the new parse_wireaddr, which has been updated to parse ports. They are
inverses now.

Also add some tests that check this.

Signed-off-by: William Casarin <jb55@jb55.com>

7 years ago

William Casarin

3e7aabe256

test: add tests for parse_ip_port

This tests the basic functionality of parse_ip_port, which is used in
parse_wireaddr.

Signed-off-by: William Casarin <jb55@jb55.com>

7 years ago

3 Commits (bd07a917828cc0deb9da124fb5aa923ef6d54d91)