lightning

5051 Commits

55 Branches

107 Tags

38 MiB

Tree: c3e96e058e

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Rusty Russell	ab9d9ef3b8	gossipd: drain fd instead of passing around gossip index. (This was sitting in my gossip-enchancement patch queue, but it simplifies this set too, so I moved it here). In `94711969f` we added an explicit gossip_index so when gossipd gets peers back from other daemons, it knows what gossip it has sent (since gossipd can send gossip after the other daemon is already complete). This solution is insufficient for the more general case where gossipd wants to send other messages reliably, so replace it with the other solution: have gossipd drain the "gossip fd" which the daemon returns. This turns out to be quite simple, and is probably how I should have done it originally :( Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago
Rusty Russell	d2b4e09e27	lightningd: re-allow closing negotiation when CLOSINGD_COMPLETE `d822ba1ee` accidentally removed this case, which is important: if the other side didn't get our final matching closing_signed, it will reconnect and try again. We consider the channel no longer "active" and thus ignore it, and get upset when it send the `channel_reestablish` message. We could just consider CLOSINGD_COMPLETE to be active, but then we'd have to wait for the closing transaction to be mined before we'd allow another connection. We can't special case it when the peer reconnects, because there could be (in theory) multiple channels for that peer in CLOSINGD_COMPLETE, and we don't know which one to reestablish. So, we need to catch this when they send the reestablish, and hand that msg to closingd to do negotiation again. We already have code to note that we're in CLOSINGD_COMPLETE and thus ignore any result it gives us. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago
Rusty Russell	9176ee628c	lightningd/closing_control: routines to control closingd (move from peer_control.c) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	7 years ago

Rusty Russell

ab9d9ef3b8

gossipd: drain fd instead of passing around gossip index.

(This was sitting in my gossip-enchancement patch queue, but it simplifies
this set too, so I moved it here).

In 94711969f we added an explicit gossip_index so when gossipd gets
peers back from other daemons, it knows what gossip it has sent (since
gossipd can send gossip after the other daemon is already complete).

This solution is insufficient for the more general case where gossipd
wants to send other messages reliably, so replace it with the other
solution: have gossipd drain the "gossip fd" which the daemon returns.

This turns out to be quite simple, and is probably how I should have
done it originally :(

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7 years ago

Rusty Russell

d2b4e09e27

lightningd: re-allow closing negotiation when CLOSINGD_COMPLETE

d822ba1ee accidentally removed this case, which is important: if the
other side didn't get our final matching closing_signed, it will
reconnect and try again.  We consider the channel no longer "active"
and thus ignore it, and get upset when it send the
`channel_reestablish` message.

We could just consider CLOSINGD_COMPLETE to be active, but then we'd
have to wait for the closing transaction to be mined before we'd allow
another connection.

We can't special case it when the peer reconnects, because there
could be (in theory) multiple channels for that peer in CLOSINGD_COMPLETE,
and we don't know which one to reestablish.

So, we need to catch this when they send the reestablish, and hand
that msg to closingd to do negotiation again.  We already have code
to note that we're in CLOSINGD_COMPLETE and thus ignore any result
it gives us.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7 years ago

Rusty Russell

9176ee628c

lightningd/closing_control: routines to control closingd (move from peer_control.c)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

7 years ago

3 Commits (c3e96e058e9f6023754bc99c27d5f254537a01db)