lightning

8310 Commits

55 Branches

107 Tags

38 MiB

Tree: c6656dcbe8

Commit Graph

Author	SHA1	Message	Date
niftynei	722fa1df6c	psbt-utils: ignore the 'unknown' map for input + output comparison There's no stable ordering on unknown serialization, so linearizing identical but mis-ordered unknown data will lead to 'wrong' results. Instead, we just ignore any data that's in the psbt unknown struct. There's probably also problems here with other PSBT maps. Really, this needs a finer grained comparison function .... fuck	5 years ago
niftynei	c0d0272eac	psbt-common: shared psbt utilities includes facilities for - sorting psbt inputs by serial_id - sorting psbt outputs by serial_id - adding a serial_id - getting a serial_id - finding the diffset between two psbts - adding a max_len to a psbt input - getting a max_len from a psbt input	5 years ago

Author

SHA1

Message

Date

niftynei

722fa1df6c

psbt-utils: ignore the 'unknown' map for input + output comparison

There's no stable ordering on unknown serialization, so linearizing
identical but mis-ordered unknown data will lead to 'wrong' results.
Instead, we just ignore any data that's in the psbt unknown struct.

There's probably also problems here with other PSBT maps. Really, this
needs a finer grained comparison function .... fuck

5 years ago

niftynei

c0d0272eac

psbt-common: shared psbt utilities

includes facilities for
  - sorting psbt inputs by serial_id
  - sorting psbt outputs by serial_id
  - adding a serial_id
  - getting a serial_id
  - finding the diffset between two psbts
  - adding a max_len to a psbt input
  - getting a max_len from a psbt input

5 years ago

2 Commits (c6656dcbe8944fe5227758247d00c72d9899b015)