lightning

6778 Commits

55 Branches

107 Tags

38 MiB

Tree: d33ebd3629

Commit Graph

Author	SHA1	Message	Date
Rusty Russell	6c335dfcc6	plugins: don't crash if getmanifest times out. I mean, we still crash, but we give an error now :) lightningd: FATAL SIGNAL 11 (version v0.7.1-82-g92c38a0) 0x5592e75e19c8 send_backtrace common/daemon.c:40 0x5592e75e1a6e crashdump common/daemon.c:53 0x7fad1514ef5f ??? ???:0 0x5592e75b2f3a io_loop_with_timers lightningd/io_loop_with_timers.c:29 0x5592e75d8a54 plugins_init lightningd/plugin.c:1018 0x5592e75b8e22 main lightningd/lightningd.c:671 0x7fad15131b6a ??? ???:0 0x5592e75a10f9 ??? ???:0 0xffffffffffffffff ??? ???:0 Segmentation fault (core dumped) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	6 years ago
Rusty Russell	d5bd1682f5	lightningd: free timers on shutdown. Direct leak of 1024 byte(s) in 2 object(s) allocated from: #0 0x7f4c84ce4448 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10c448) #1 0x55d11b782c96 in timer_default_alloc ccan/ccan/timer/timer.c:16 #2 0x55d11b7832b7 in add_level ccan/ccan/timer/timer.c:166 #3 0x55d11b783864 in timer_fast_forward ccan/ccan/timer/timer.c:334 #4 0x55d11b78396a in timers_expire ccan/ccan/timer/timer.c:359 #5 0x55d11b774993 in io_loop ccan/ccan/io/poll.c:395 #6 0x55d11b72322f in plugins_init lightningd/plugin.c:1013 #7 0x55d11b7060ea in main lightningd/lightningd.c:664 #8 0x7f4c84696b6a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x26b6a) To fix this, we actually make 'ld->timers' a pointer, so we can clean it up last of all. We can't free it before ld, because that causes timers to be destroyed. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	6 years ago
ZmnSCPxj	48df6c8566	lightningd/io_loop_with_timers.c: Move mainloop to its own source file, have chaintopology use it. Fixes: #2687	6 years ago

Author

SHA1

Message

Date

Rusty Russell

6c335dfcc6

plugins: don't crash if getmanifest times out.

I mean, we still crash, but we give an error now :)

lightningd: FATAL SIGNAL 11 (version v0.7.1-82-g92c38a0)
0x5592e75e19c8 send_backtrace
	common/daemon.c:40
0x5592e75e1a6e crashdump
	common/daemon.c:53
0x7fad1514ef5f ???
	???:0
0x5592e75b2f3a io_loop_with_timers
	lightningd/io_loop_with_timers.c:29
0x5592e75d8a54 plugins_init
	lightningd/plugin.c:1018
0x5592e75b8e22 main
	lightningd/lightningd.c:671
0x7fad15131b6a ???
	???:0
0x5592e75a10f9 ???
	???:0
0xffffffffffffffff ???
	???:0
Segmentation fault (core dumped)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

6 years ago

Rusty Russell

d5bd1682f5

lightningd: free timers on shutdown.

Direct leak of 1024 byte(s) in 2 object(s) allocated from:
    #0 0x7f4c84ce4448 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10c448)
    #1 0x55d11b782c96 in timer_default_alloc ccan/ccan/timer/timer.c:16
    #2 0x55d11b7832b7 in add_level ccan/ccan/timer/timer.c:166
    #3 0x55d11b783864 in timer_fast_forward ccan/ccan/timer/timer.c:334
    #4 0x55d11b78396a in timers_expire ccan/ccan/timer/timer.c:359
    #5 0x55d11b774993 in io_loop ccan/ccan/io/poll.c:395
    #6 0x55d11b72322f in plugins_init lightningd/plugin.c:1013
    #7 0x55d11b7060ea in main lightningd/lightningd.c:664
    #8 0x7f4c84696b6a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x26b6a)

To fix this, we actually make 'ld->timers' a pointer, so we can clean
it up last of all.  We can't free it before ld, because that causes
timers to be destroyed.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

6 years ago

ZmnSCPxj

48df6c8566

lightningd/io_loop_with_timers.c: Move mainloop to its own source file, have chaintopology use it.

Fixes: #2687

6 years ago

3 Commits (d33ebd36295c3ad16d41e23d3dd0eb9eee0e6310)