lightning

History

Mark Beckwith 7f437715d5 Added error code parameter to command_fail Until now, `command_fail()` reported an error code of -1 for all uses. This PR adds an `int code` parameter to `command_fail()`, requiring the caller to explicitly include the error code. This is part of #1464. The majority of the calls are used during parameter validation and their error code is now JSONRPC2_INVALID_PARAMS. The rest of the calls report an error code of LIGHTNINGD, which I defined to -1 in `jsonrpc_errors.h`. The intention here is that as we improve our error reporting, all occurenaces of LIGHTNINGD will go away and we can eventually remove it. I also converted calls to `command_fail_detailed()` that took a `NULL` `data` parameter to use the new `command_fail()`. The only difference from an end user perspecive is that bad input errors that used to be -1 will now be -32602 (JSONRPC2_INVALID_PARAMS).		7 years ago
..
test	features: fix features_supported() function.	7 years ago
Makefile	common/tor: move into lightningd.	7 years ago
base32.c	common/base32: make this a simple tal-wrapper around ccan/base32.	7 years ago
base32.h	common/base32: make this a simple tal-wrapper around ccan/base32.	7 years ago
bech32.c	Remove include in file foo.c that is already included in foo.h	7 years ago
bech32.h	Use expected LIGHTNING_DIR_FILE_H define	7 years ago
bech32_util.c	common: Moving some bech32 related utilities to bech32_util	7 years ago
bech32_util.h	common: Moving some bech32 related utilities to bech32_util	7 years ago
bip32.c	common: move some files out of lightningd/	7 years ago
bip32.h	headers: fix up header idempotent lines.	7 years ago
bolt11.c	common: Moving some bech32 related utilities to bech32_util	7 years ago
bolt11.h	bolt11: allow multiple fallback addresses.	7 years ago
channel_config.c	common: move some files out of lightningd/	7 years ago
channel_config.h	Revert "Send/receive cltv_expiry_delta in open/accept channel."	7 years ago
close_tx.c	bitcoin: create new wrapper type bitcoin_txid, log backward endianness.	7 years ago
close_tx.h	Use expected LIGHTNING_DIR_FILE_H define	7 years ago
configdir.c	lightningd: fix double-specified args.	7 years ago
configdir.h	options: don't leak memory when people override options.	7 years ago
crypto_state.c	crypto_state: move to its own file.	7 years ago
crypto_state.h	crypto_state: move to its own file.	7 years ago
crypto_sync.c	status: make status_io a more generic mechanism.	7 years ago
crypto_sync.h	headers: fix up header idempotent lines.	7 years ago
cryptomsg.c	status: make status_io a more generic mechanism.	7 years ago
cryptomsg.h	gossipd: fix race where we can handoff peer with bad cryptostate.	7 years ago
daemon.c	bt_print and bt_exit is enclosed in the conditional	7 years ago
daemon.h	common/daemon: common routines for all daemons.	7 years ago
daemon_conn.c	daemon_conn: simplify msg_queue_cleared_cb.	7 years ago
daemon_conn.h	daemon_conn: simplify msg_queue_cleared_cb.	7 years ago
derive_basepoints.c	Remove include in file foo.c that is already included in foo.h	7 years ago
derive_basepoints.h	basepoints/secrets: add htlc entry	7 years ago
dev_disconnect.c	Spelling corrections (#824)	7 years ago
dev_disconnect.h	Add DEVELOPER flag, set by default.	7 years ago
features.c	features: fix features_supported() function.	7 years ago
features.h	features: more general accessor functions.	7 years ago
funding_tx.c	common: remove unused assert() headers.	7 years ago
funding_tx.h	bitcoin: create new wrapper type bitcoin_txid, log backward endianness.	7 years ago
hash_u5.c	common/hash_u5: routines to hash 5 bit values.	7 years ago
hash_u5.h	common/hash_u5: routines to hash 5 bit values.	7 years ago
htlc.h	Remove unused functions not covered by unit tests	7 years ago
htlc_state.c	common: absorb remaining files from daemon/	7 years ago
htlc_state.h	Fix a-vs-an typos	7 years ago
htlc_tx.c	bitcoin: create new wrapper type bitcoin_txid, log backward endianness.	7 years ago
htlc_tx.h	bitcoin: create new wrapper type bitcoin_txid, log backward endianness.	7 years ago
htlc_wire.c	tools/generate_wire.py: make varlen structs self-allocate.	7 years ago
htlc_wire.h	tools/generate_wire.py: make varlen structs self-allocate.	7 years ago
initial_channel.c	openingd: ensure that initial channel can cover fees and reserve.	7 years ago
initial_channel.h	openingd: ensure that initial channel can cover fees and reserve.	7 years ago
initial_commit_tx.c	openingd: ensure that initial channel can cover fees and reserve.	7 years ago
initial_commit_tx.h	openingd: ensure that initial channel can cover fees and reserve.	7 years ago
json.c	jsonrpc: Pretty-print the json results	7 years ago
json.h	Remove unused functions not covered by unit tests	7 years ago
json_escaped.c	Remove unused functions not covered by unit tests	7 years ago
json_escaped.h	Remove unused functions not covered by unit tests	7 years ago
key_derive.c	basepoints/secrets: add htlc entry	7 years ago
key_derive.h	headers: fix up header idempotent lines.	7 years ago
keyset.c	typo	7 years ago
keyset.h	basepoints/secrets: add htlc entry	7 years ago
memleak.c	Remove include in file foo.c that is already included in foo.h	7 years ago
memleak.h	Re-enable builds with DEVELOPER=0	7 years ago
msg_queue.c	common: move some files out of lightningd/	7 years ago
msg_queue.h	headers: fix up header idempotent lines.	7 years ago
overflows.h	The overflow check mul_overflows_s64(int64_t, int64_t) overflows and triggers UB :-) Remove it	7 years ago
peer_billboard.c	common: peer_billboard() helper for updating the billboard.	7 years ago
peer_billboard.h	common: peer_billboard() helper for updating the billboard.	7 years ago
peer_failed.c	gossipd: drain fd instead of passing around gossip index.	7 years ago
peer_failed.h	gossipd: drain fd instead of passing around gossip index.	7 years ago
peer_status_wire.csv	gossipd: drain fd instead of passing around gossip index.	7 years ago
permute_tx.c	permute_tx: bail on empty permute_{inputs/outputs} arguments	7 years ago
permute_tx.h	headers: fix up header idempotent lines.	7 years ago
ping.c	pong: embed version string into ping replies if DEVELOPER=1.	7 years ago
ping.h	pong: embed version string into ping replies if DEVELOPER=1.	7 years ago
pseudorand.c	common: absorb remaining files from daemon/	7 years ago
pseudorand.h	headers: fix up header idempotent lines.	7 years ago
read_peer_msg.c	common: typo fix.	7 years ago
read_peer_msg.h	read_peer_msg: handle incoming gossip from gossipd.	7 years ago
socket_close.c	closingd: Ensure proper closing of TCP socket.	7 years ago
socket_close.h	closingd: Ensure proper closing of TCP socket.	7 years ago
sphinx.c	Remove include in file foo.c that is already included in foo.h	7 years ago
sphinx.h	headers: fix up header idempotent lines.	7 years ago
status.c	status: make status_io a more generic mechanism.	7 years ago
status.h	status: make status_io a more generic mechanism.	7 years ago
status_levels.h	status: separate types for peer failure vs "impossible" failures.	7 years ago
status_wire.c	status: generate messages rather than marshal/unmarshal manually.	7 years ago
status_wire.csv	status: make status_io a more generic mechanism.	7 years ago
status_wire.h	status: generate messages rather than marshal/unmarshal manually.	7 years ago
subdaemon.c	common/daemon: common routines for all daemons.	7 years ago
subdaemon.h	common/daemon: common routines for all daemons.	7 years ago
timeout.c	utils: remove tal_tmpctx altogether, use global.	7 years ago
timeout.h	headers: fix up header idempotent lines.	7 years ago
type_to_string.c	Fix order of includes	7 years ago
type_to_string.h	wireaddr_internal: new type for where we can also use a local socket.	7 years ago
utils.c	Force the use of the POSIX C locale for all commands and their subprocesses	7 years ago
utils.h	Force the use of the POSIX C locale for all commands and their subprocesses	7 years ago
utxo.c	tools/generate_wire.py: generate varlen arrays properly.	7 years ago
utxo.h	cleanup: Make blockheights unsigned	7 years ago
version.c	Make version output simpler/more user-friendly	7 years ago
version.h	Onboarding: Make log output texts friendlier to new users	7 years ago
wallet_tx.c	Added error code parameter to command_fail	7 years ago
wallet_tx.h	Removed redundancies in withdraw and fundchannel.	7 years ago
wire_error.c	Remove duplicate va_end(...) call. va_end(...) is the responsibility of the caller.	7 years ago
wire_error.h	Spelling corrections (#824)	7 years ago
wireaddr.c	wireaddr: Avoid memory corruption in fmt_wireaddr_without_port()	7 years ago
wireaddr.h	wireaddr: new type, ADDR_INTERNAL_FORPROXY, use it if we can't/wont resolve.	7 years ago
withdraw_tx.c	travis: reenable check-source (without BOLT text).	7 years ago
withdraw_tx.h	Change withdraw_tx to accept scriptpubkey rather than plain address.	7 years ago