Merge pull request #381 from mendersoftware/QA-322-align-with-release-process

QA-322: Align pipeline with Mender release process

.gitlab-ci.yml

@@ -2,28 +2,29 @@
 variables:
   DOCKER_REPOSITORY: mendersoftware/mender-convert
   S3_BUCKET_NAME: mender-convert-images
+
   # These variables are present elsewhere in the repository too. Make sure to
   # search for and change them too.
   MENDER_ARTIFACT_VERSION: master
   MENDER_CLIENT_VERSION: latest
   MENDER_ADDON_CONNECT_VERSION: latest
   MENDER_ADDON_CONFIGURE_VERSION: latest
+
   # Make sure to update the link in mender-docs to the new one when changing
   # this.
   RASPBIAN_URL: https://downloads.raspberrypi.org/raspios_lite_armhf/images/raspios_lite_armhf-2021-01-12/2021-01-11-raspios-buster-armhf-lite.zip
   RASPBIAN_NAME: 2021-01-11-raspios-buster-armhf-lite
 
-  TEST_MENDER_CONVERT: "true"
-
   # Which version of mender-convert to use in published image name. Normally
   # empty, in which case the branch or tag name will be used, but this variable
   # is available so that it's possible to make small build fixes on an already
   # tagged version.
   MENDER_CONVERT_PUBLISH_VERSION: ""
 
-  # Whether to publish images. Note that images from branches are always
-  # published, even if this is false.
-  PUBLISH_MENDER_CONVERT_IMAGES: "false"
+  # Whether to run acceptance tests
+  TEST_MENDER_CONVERT: "true"
+  # Whether to publish packages automatically - they can always be published manually
+  PUBLISH_MENDER_CONVERT_AUTOMATIC: "false"
 
   DEBIAN_FRONTEND: noninteractive
 
@@ -53,6 +54,25 @@ stages:
   - test_acceptance
   - publish
 
+test:check-commits:
+  only:
+    variables:
+      - '$TEST_MENDER_CONVERT == "true"'
+
+test:check-license:
+  rules:
+    - if: '$TEST_MENDER_CONVERT == "true"'
+
+test:check-shell-formatting:
+  rules:
+    - if: '$TEST_MENDER_CONVERT == "true"'
+  before_script:
+    - SHELL_SCRIPTS=$(find mender-convert* modules configs scripts
+            -type f
+            -not -name "*.md"
+            -not -path "scripts/linkbot/*"
+            -not -wholename "scripts/test/*")
+
 build:
   stage: build
   needs: []
@@ -67,14 +87,6 @@ build:
     paths:
       - image.tar
 
-test:check-shell-formatting:
-  before_script:
-    - SHELL_SCRIPTS=$(find mender-convert* modules configs scripts
-            -type f
-            -not -name "*.md"
-            -not -path "scripts/linkbot/*"
-            -not -wholename "scripts/test/*")
-
 .template_convert_raspbian: &convert_raspbian
   stage: convert
   needs:
@@ -98,14 +110,10 @@ test:check-shell-formatting:
     - unzip ${RASPBIAN_NAME}.zip
 
   script:
-    - echo "MENDER_CLIENT_VERSION=${MENDER_CLIENT_VERSION}" > versions_override_config
-    - echo "MENDER_ADDON_CONNECT_VERSION=${MENDER_ADDON_CONNECT_VERSION}" >> versions_override_config
-    - echo "MENDER_ADDON_CONFIGURE_VERSION=${MENDER_ADDON_CONFIGURE_VERSION}" >> versions_override_config
-    - env MENDER_ARTIFACT_NAME=${RASPBIAN_NAME}-mender-${MENDER_CLIENT_VERSION}
-      ./docker-mender-convert -d ${RASPBIAN_NAME}.img
-      -c configs/${RASPBERRYPI_PLATFORM}_config
-      -c configs/images/raspberrypi_raspbian_config
-      -c versions_override_config
+    - env MENDER_ARTIFACT_NAME=${RASPBIAN_NAME}-mender
+      ./docker-mender-convert --disk-image ${RASPBIAN_NAME}.img
+      --config configs/${RASPBERRYPI_PLATFORM}_config
+      --config configs/images/raspberrypi_raspbian_config
 
     # Collect artifacts.
     - mv deploy ${RASPBERRYPI_PLATFORM}
@@ -240,7 +248,7 @@ test_acceptance_ubuntu:
   script:
     - ./scripts/test/run-tests.sh --config versions_override_config --only ubuntu
 
-publish:s3:
+.template:publish:s3:
   stage: publish
   image: debian:buster
   before_script:
@@ -279,7 +287,11 @@ publish:s3:
           --key ${RASPBIAN_NAME}/arm/${PUBLISH_NAME}
     - done
 
+publish:s3:manual:
+  when: manual
+  extends: .template:publish:s3
+
+publish:s3:automatic:
   rules:
-    - if: '$CI_COMMIT_REF_NAME =~ /^[0-9]+\.[0-9]+\.[0-9]+(-build[0-9]+)?$/ && $PUBLISH_MENDER_CONVERT_IMAGES == "true"'
-    - if: '$CI_COMMIT_REF_NAME =~ /^(master|[0-9]+\.[0-9]+\.x)$/'
-    - if: '$CI_COMMIT_REF_NAME !~ /^pr_[0-9]+$/ && $MENDER_CONVERT_PUBLISH_VERSION != "" && $PUBLISH_MENDER_CONVERT_IMAGES == "true"'
+    - if: '$PUBLISH_MENDER_CONVERT_AUTOMATIC == "true"'
+  extends: .template:publish:s3