add .eslintrc file, eslint fix script. add deps: prettier, prettier-eslint, eslint, eslint-plugin-react. use config from neutrino-preset-mozilla-rpweb

.eslintrc.js

@@ -0,0 +1,95 @@
+module.exports = {
+  'ecmaVersion': 2017,
+
+  // http://eslint.org/docs/user-guide/configuring#specifying-parser-options
+  'ecmaFeatures': {
+    'jsx': true,
+    'modules': true,
+    'decorators': true,
+    'experimentalObjectRestSpread': true,
+  },
+
+  'env': {
+    'node': true,
+    'browser': true,
+    'es6': true,
+    'worker': true,
+    'serviceworker': true,
+  },
+  'plugins': [
+    'react',
+    'eslint-plugin-prettier',
+  ],
+  'rules': {
+    // Specify the maximum length of a line in your program
+    // JSX can get lengthy, so this helps alleviate that a bit
+    // http://eslint.org/docs/rules/max-len
+    'max-len': ['error', 120, 2, {
+      ignoreUrls: true,
+      ignoreComments: false,
+      ignoreStrings: true,
+      ignoreTemplateLiterals: true
+    }],
+
+    // Allow using class methods with static/non-instance functionality
+    // React lifecycle methods commonly do not use an instance context for anything
+    'class-methods-use-this': 'off',
+
+    // Disallow trailing commas on arrays, objects, functions, et al
+    'comma-dangle': ['error', 'never'],
+
+    // Prefer double or quotes in JSX attributes
+    // http://eslint.org/docs/rules/jsx-quotes
+    'jsx-quotes': ['error', 'prefer-double'],
+
+    // Allow console during development, otherwise throw an error
+    'no-console': 'warn',
+
+    // Allow extra parentheses since multiline JSX being wrapped in parens is considered idiomatic
+    'no-extra-parens': 'off',
+
+    // Our frontend strives to adopt functional programming practices, so we prefer const over let
+    'prefer-const': 'error',
+
+    // Force JSX closing bracket to be placed right after last prop
+    'react/jsx-closing-bracket-location': ['error', 'after-props'],
+
+    // Disallow spaces for JSX attribute braces interior
+    // JSX braces are interpolation, not objects
+    'react/jsx-curly-spacing': ['error', 'never'],
+
+    // Disallow spaces around JSX attribute assignment equals (idiomatic HTML)
+    'react/jsx-equals-spacing': ['error', 'never'],
+
+    // Require JSX props to be on new lines when a component is multiline, improves readability
+    'react/jsx-first-prop-new-line': ['error', 'multiline'],
+
+    // Ensure JSX indentation uses 2 spaces
+    'react/jsx-indent': ['error', 2],
+
+    // Ensure JSX props are indented 2 spaces from opening tag
+    'react/jsx-indent-props': ['error', 2],
+
+    // Validate JSX has key prop when in array or iterator
+    'react/jsx-key': 'error',
+
+    // Prevent comments from being inserted as text nodes
+    'react/jsx-no-comment-textnodes': 'error',
+
+    // Prevent usage of unsafe target="_blank", ensure anchors also have rel="noreferrer noopener"
+    'react/jsx-no-target-blank': 'error',
+
+    // Ensure JSX components are PascalCase
+    'react/jsx-pascal-case': 'error',
+
+    // Require space before self-closing bracket in JSX
+    'react/jsx-space-before-closing': ['error', 'always'],
+
+    // Ensure multiline JSX is wrapped in parentheses (idiomatic React)
+    // Must be coupled with no-extra-parens: off
+    'react/jsx-wrap-multilines': 'error',
+
+    // Disable enforcement of React PropTypes
+    'react/prop-types': 'off'
+  }
+}

package.json

@@ -8,6 +8,7 @@
   "bugs": "https://github.com/mozilla-neutrino/neutrino-dev/issues",
   "repository": "mozilla-neutrino/neutrino-dev",
   "scripts": {
+    "lint": "eslint packages/**/*.js --fix",
     "bootstrap": "oao bootstrap",
     "changelog": "changelog mozilla-neutrino/neutrino-dev all --markdown > CHANGELOG.md",
     "deps:add": "oao add",
@@ -22,6 +23,9 @@
   },
   "devDependencies": {
     "changelog": "^1.0.7",
+    "eslint": "^3.17.1",
+    "eslint-plugin-prettier": "^2.0.1",
+    "eslint-plugin-react": "^6.10.0",
     "gh-pages": "^0.12.0",
     "gitbook-cli": "^2.3.0",
     "gitbook-plugin-anchorjs": "^1.1.1",
@@ -29,6 +33,7 @@
     "gitbook-plugin-github": "^2.0.0",
     "gitbook-plugin-npmsearchlist": "^1.0.0",
     "gitbook-plugin-prism": "^2.1.0",
-    "oao": "^0.5.7"
+    "oao": "^0.5.7",
+    "prettier": "^0.21.0"
   }
 }

packages/neutrino-preset-web/src/index.js

@@ -168,7 +168,7 @@ module.exports = ({ config }) => {
         useShortDoctype: true,
         keepClosingSlash: true,
         collapseWhitespace: true,
-        preserveLineBreaks: true,
+        preserveLineBreaks: true
       }
     }, PKG.config && PKG.config.html ? PKG.config.html : {}));