lukechilds
/
node-cache-manager
mirror of https://github.com/lukechilds/node-cache-manager.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

release 0.0.3

hotfix/0.7.1
Bryan Donovan 12 years ago
parent
90e1615e5c
commit
0ae7a2b42b
4 changed files with 50 additions and 19 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 9
      History.md
  2. 3
      lib/caching.js
  3. 2
      package.json
  4. 55
      test/caching.unit.js

9
History.md
View File

@ -1,10 +1,13 @@
- 0.0.1 - 0.0.3 2013-07-10
Initial release. Better error checking in cache.wrap();
- 0.0.2 - 0.0.2 2013-04-08
Added ability to pass in a store module that isn't already instantiated. Added ability to pass in a store module that isn't already instantiated.
E.g., E.g.,
```javascript ```javascript
var store = require('/path/my_memory_store'); var store = require('/path/my_memory_store');
cache = caching({store: store}); cache = caching({store: store});
``` ```
- 0.0.1 2013-04-08
Initial release.

3
lib/caching.js
View File

@ -37,6 +37,9 @@ var caching = function (args) {
work(function () { work(function () {
var work_args = Array.prototype.slice.call(arguments, 0); var work_args = Array.prototype.slice.call(arguments, 0);
if (work_args[0]) { // assume first arg is an error
return cb(work_args[0]);
}
self.store.set(key, work_args[1], function (err) { self.store.set(key, work_args[1], function (err) {
if (err) { return cb(err); } if (err) { return cb(err); }
cb.apply(null, work_args); cb.apply(null, work_args);

2
package.json
View File

@ -1,6 +1,6 @@
{ {
"name": "cache-manager", "name": "cache-manager",
"version": "0.0.2", "version": "0.0.3",
"description": "Cache module for Node.js", "description": "Cache module for Node.js",
"main": "index.js", "main": "index.js",
"scripts": { "scripts": {

55
test/caching.unit.js
View File

@ -6,9 +6,11 @@ var check_err = support.check_err;
var caching = require('../index').caching; var caching = require('../index').caching;
var memory_store = require('../lib/stores/memory'); var memory_store = require('../lib/stores/memory');
function get_widget(name, cb) { var methods = {
cb(null, {name: name}); get_widget: function (name, cb) {
} cb(null, {name: name});
}
};
describe("caching", function () { describe("caching", function () {
var cache; var cache;
@ -116,7 +118,7 @@ describe("caching", function () {
it("calls back with the result of the wrapped function", function (done) { it("calls back with the result of the wrapped function", function (done) {
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err, widget) { }, function (err, widget) {
check_err(err); check_err(err);
assert.deepEqual(widget, {name: name}); assert.deepEqual(widget, {name: name});
@ -126,7 +128,7 @@ describe("caching", function () {
it("caches the result of the function in redis", function (done) { it("caches the result of the function in redis", function (done) {
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err, widget) { }, function (err, widget) {
check_err(err); check_err(err);
assert.ok(widget); assert.ok(widget);
@ -140,9 +142,32 @@ describe("caching", function () {
}); });
}); });
context("when wrapped function calls back with an error", function () {
it("calls back with that error and doesn't cache result", function (done) {
var fake_error = new Error(support.random.string());
sinon.stub(methods, 'get_widget', function (name, cb) {
cb(fake_error, {name: name});
});
cache.wrap(key, function (cb) {
methods.get_widget(name, cb);
}, function (err, widget) {
methods.get_widget.restore();
assert.equal(err, fake_error);
assert.ok(!widget);
redis_client.get(key, function (err, result) {
check_err(err);
assert.ok(!result);
done();
});
});
});
});
it("retrieves data from redis when available", function (done) { it("retrieves data from redis when available", function (done) {
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err, widget) { }, function (err, widget) {
check_err(err); check_err(err);
assert.ok(widget); assert.ok(widget);
@ -154,7 +179,7 @@ describe("caching", function () {
sinon.spy(redis_client, 'get'); sinon.spy(redis_client, 'get');
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err, widget) { }, function (err, widget) {
check_err(err); check_err(err);
assert.deepEqual(widget, {name: name}); assert.deepEqual(widget, {name: name});
@ -174,7 +199,7 @@ describe("caching", function () {
it("expires cached result after ttl seconds", function (done) { it("expires cached result after ttl seconds", function (done) {
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err, widget) { }, function (err, widget) {
check_err(err); check_err(err);
assert.ok(widget); assert.ok(widget);
@ -210,7 +235,7 @@ describe("caching", function () {
it("calls back with the result of a function", function (done) { it("calls back with the result of a function", function (done) {
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err, widget) { }, function (err, widget) {
check_err(err); check_err(err);
assert.deepEqual(widget, {name: name}); assert.deepEqual(widget, {name: name});
@ -220,7 +245,7 @@ describe("caching", function () {
it("retrieves data from memory when available", function (done) { it("retrieves data from memory when available", function (done) {
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err, widget) { }, function (err, widget) {
check_err(err); check_err(err);
assert.ok(widget); assert.ok(widget);
@ -233,7 +258,7 @@ describe("caching", function () {
var func_called = false; var func_called = false;
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, function (err, result) { methods.get_widget(name, function (err, result) {
func_called = true; func_called = true;
cb(err, result); cb(err, result);
}); });
@ -251,7 +276,7 @@ describe("caching", function () {
it("expires cached result after ttl seconds", function (done) { it("expires cached result after ttl seconds", function (done) {
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err, widget) { }, function (err, widget) {
check_err(err); check_err(err);
assert.deepEqual(widget, {name: name}); assert.deepEqual(widget, {name: name});
@ -264,7 +289,7 @@ describe("caching", function () {
setTimeout(function () { setTimeout(function () {
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, function (err, result) { methods.get_widget(name, function (err, result) {
func_called = true; func_called = true;
cb(err, result); cb(err, result);
}); });
@ -288,7 +313,7 @@ describe("caching", function () {
}); });
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err) { }, function (err) {
assert.equal(err, fake_error); assert.equal(err, fake_error);
memory_store_stub.get.restore(); memory_store_stub.get.restore();
@ -306,7 +331,7 @@ describe("caching", function () {
}); });
cache.wrap(key, function (cb) { cache.wrap(key, function (cb) {
get_widget(name, cb); methods.get_widget(name, cb);
}, function (err) { }, function (err) {
assert.equal(err, fake_error); assert.equal(err, fake_error);
memory_store_stub.set.restore(); memory_store_stub.set.restore();

Write Preview
Loading…
Cancel
Save