lukechilds
/
node
mirror of https://github.com/lukechilds/node.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
10157 Commits
131 Branches
446 Tags
325 MiB
Tree: 0dfedb7127
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '0dfedb7127'
${ noResults }
node/test/simple/test-tls-hello-parser-failu...

62 lines
2.0 KiB
Raw Normal View History

tls: retry writing after hello parse error When writing bad data to EncryptedStream it'll first get to the ClientHello parser, and, only after it will refuse it, to the OpenSSL. But ClientHello parser has limited buffer and therefore write could return `bytes_written` < `incoming_bytes`, which is not the case when working with OpenSSL. After such errors ClientHello parser disables itself and will pass-through all data to the OpenSSL. So just trying to write data one more time will throw the rest into OpenSSL and let it handle it.
12 years ago
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
var common = require('../common');
var tls = require('tls');
var net = require('net');
var fs = require('fs');
var assert = require('assert');
var options = {
key: fs.readFileSync(common.fixturesDir + '/test_key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/test_cert.pem')
};
test: fix tls-hello-parser-failure on smartos Assert that when the client closes it has seen an error, this prevents the test from timing out. Also queue a second write in the case that we were able to send the buffer before the other side closed the connection.
12 years ago
var bonkers = new Buffer(1024 * 1024);
bonkers.fill(42);
tls: retry writing after hello parse error When writing bad data to EncryptedStream it'll first get to the ClientHello parser, and, only after it will refuse it, to the OpenSSL. But ClientHello parser has limited buffer and therefore write could return `bytes_written` < `incoming_bytes`, which is not the case when working with OpenSSL. After such errors ClientHello parser disables itself and will pass-through all data to the OpenSSL. So just trying to write data one more time will throw the rest into OpenSSL and let it handle it.
12 years ago
var server = tls.createServer(options, function(c) {
}).listen(common.PORT, function() {
var client = net.connect(common.PORT, function() {
test: fix tls-hello-parser-failure on smartos Assert that when the client closes it has seen an error, this prevents the test from timing out. Also queue a second write in the case that we were able to send the buffer before the other side closed the connection.
12 years ago
client.write(bonkers);
tls: retry writing after hello parse error When writing bad data to EncryptedStream it'll first get to the ClientHello parser, and, only after it will refuse it, to the OpenSSL. But ClientHello parser has limited buffer and therefore write could return `bytes_written` < `incoming_bytes`, which is not the case when working with OpenSSL. After such errors ClientHello parser disables itself and will pass-through all data to the OpenSSL. So just trying to write data one more time will throw the rest into OpenSSL and let it handle it.
12 years ago
});
var once = false;
test: fix tls-hello-parser-failure on smartos Assert that when the client closes it has seen an error, this prevents the test from timing out. Also queue a second write in the case that we were able to send the buffer before the other side closed the connection.
12 years ago
test: fix up indentation, replace tabs with spaces
12 years ago
var writeAgain = setTimeout(function() {
client.write(bonkers);
});
test: fix tls-hello-parser-failure on smartos Assert that when the client closes it has seen an error, this prevents the test from timing out. Also queue a second write in the case that we were able to send the buffer before the other side closed the connection.
12 years ago
client.on('error', function(err) {
tls: retry writing after hello parse error When writing bad data to EncryptedStream it'll first get to the ClientHello parser, and, only after it will refuse it, to the OpenSSL. But ClientHello parser has limited buffer and therefore write could return `bytes_written` < `incoming_bytes`, which is not the case when working with OpenSSL. After such errors ClientHello parser disables itself and will pass-through all data to the OpenSSL. So just trying to write data one more time will throw the rest into OpenSSL and let it handle it.
12 years ago
if (!once) {
test: fix up indentation, replace tabs with spaces
12 years ago
clearTimeout(writeAgain);
tls: retry writing after hello parse error When writing bad data to EncryptedStream it'll first get to the ClientHello parser, and, only after it will refuse it, to the OpenSSL. But ClientHello parser has limited buffer and therefore write could return `bytes_written` < `incoming_bytes`, which is not the case when working with OpenSSL. After such errors ClientHello parser disables itself and will pass-through all data to the OpenSSL. So just trying to write data one more time will throw the rest into OpenSSL and let it handle it.
12 years ago
once = true;
client.destroy();
server.close();
}
});
test: fix tls-hello-parser-failure on smartos Assert that when the client closes it has seen an error, this prevents the test from timing out. Also queue a second write in the case that we were able to send the buffer before the other side closed the connection.
12 years ago
test: fix up indentation, replace tabs with spaces
12 years ago
client.on('close', function (hadError) {
assert.strictEqual(hadError, true, 'Client never errored');
});
tls: retry writing after hello parse error When writing bad data to EncryptedStream it'll first get to the ClientHello parser, and, only after it will refuse it, to the OpenSSL. But ClientHello parser has limited buffer and therefore write could return `bytes_written` < `incoming_bytes`, which is not the case when working with OpenSSL. After such errors ClientHello parser disables itself and will pass-through all data to the OpenSSL. So just trying to write data one more time will throw the rest into OpenSSL and let it handle it.
12 years ago
});