|
|
|
|
'use strict';
|
|
|
|
|
const common = require('../common');
|
|
|
|
|
const assert = require('assert');
|
|
|
|
|
const Stream = require('stream').Stream;
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
const source = new Stream();
|
|
|
|
|
const dest = new Stream();
|
|
|
|
|
|
|
|
|
|
source.pipe(dest);
|
|
|
|
|
|
|
|
|
|
let gotErr = null;
|
|
|
|
|
source.on('error', function(err) {
|
|
|
|
|
gotErr = err;
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const err = new Error('This stream turned into bacon.');
|
|
|
|
|
source.emit('error', err);
|
|
|
|
|
assert.strictEqual(gotErr, err);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
const source = new Stream();
|
|
|
|
|
const dest = new Stream();
|
|
|
|
|
|
|
|
|
|
source.pipe(dest);
|
|
|
|
|
|
|
|
|
|
const err = new Error('This stream turned into bacon.');
|
|
|
|
|
|
|
|
|
|
let gotErr = null;
|
|
|
|
|
try {
|
|
|
|
|
source.emit('error', err);
|
|
|
|
|
} catch (e) {
|
|
|
|
|
gotErr = e;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
assert.strictEqual(gotErr, err);
|
|
|
|
|
}
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
|
{
|
|
|
|
|
const R = Stream.Readable;
|
|
|
|
|
const W = Stream.Writable;
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
|
const r = new R();
|
|
|
|
|
const w = new W();
|
|
|
|
|
let removed = false;
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
|
r._read = common.mustCall(function() {
|
|
|
|
|
setTimeout(common.mustCall(function() {
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
assert(removed);
|
|
|
|
|
assert.throws(function() {
|
|
|
|
|
w.emit('error', new Error('fail'));
|
|
|
|
|
});
|
|
|
|
|
}));
|
|
|
|
|
});
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
|
w.on('error', myOnError);
|
|
|
|
|
r.pipe(w);
|
|
|
|
|
w.removeListener('error', myOnError);
|
|
|
|
|
removed = true;
|
|
|
|
|
|
|
|
|
|
function myOnError(er) {
|
|
|
|
|
throw new Error('this should not happen');
|
|
|
|
|
}
|
|
|
|
|
}
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
|
{
|
|
|
|
|
const R = Stream.Readable;
|
|
|
|
|
const W = Stream.Writable;
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
|
const r = new R();
|
|
|
|
|
const w = new W();
|
|
|
|
|
let removed = false;
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
|
r._read = common.mustCall(function() {
|
|
|
|
|
setTimeout(common.mustCall(function() {
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
assert(removed);
|
|
|
|
|
w.emit('error', new Error('fail'));
|
|
|
|
|
}));
|
|
|
|
|
});
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
|
w.on('error', common.mustCall(function(er) {}));
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
w._write = function() {};
|
|
|
|
|
|
|
|
|
|
r.pipe(w);
|
|
|
|
|
// Removing some OTHER random listener should not do anything
|
|
|
|
|
w.removeListener('error', function() {});
|
|
|
|
|
removed = true;
|
|
|
|
|
}
|
