|
|
|
'use strict';
|
|
|
|
require('../common');
|
|
|
|
var assert = require('assert');
|
|
|
|
var Stream = require('stream').Stream;
|
|
|
|
|
|
|
|
(function testErrorListenerCatches() {
|
|
|
|
var source = new Stream();
|
|
|
|
var dest = new Stream();
|
|
|
|
|
|
|
|
source.pipe(dest);
|
|
|
|
|
|
|
|
var gotErr = null;
|
|
|
|
source.on('error', function(err) {
|
|
|
|
gotErr = err;
|
|
|
|
});
|
|
|
|
|
|
|
|
var err = new Error('This stream turned into bacon.');
|
|
|
|
source.emit('error', err);
|
|
|
|
assert.strictEqual(gotErr, err);
|
|
|
|
})();
|
|
|
|
|
|
|
|
(function testErrorWithoutListenerThrows() {
|
|
|
|
var source = new Stream();
|
|
|
|
var dest = new Stream();
|
|
|
|
|
|
|
|
source.pipe(dest);
|
|
|
|
|
|
|
|
var err = new Error('This stream turned into bacon.');
|
|
|
|
|
|
|
|
var gotErr = null;
|
|
|
|
try {
|
|
|
|
source.emit('error', err);
|
|
|
|
} catch (e) {
|
|
|
|
gotErr = e;
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.strictEqual(gotErr, err);
|
|
|
|
})();
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
|
|
|
|
(function testErrorWithRemovedListenerThrows() {
|
|
|
|
var R = Stream.Readable;
|
|
|
|
var W = Stream.Writable;
|
|
|
|
|
|
|
|
var r = new R();
|
|
|
|
var w = new W();
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
var removed = false;
|
|
|
|
var didTest = false;
|
|
|
|
|
|
|
|
process.on('exit', function() {
|
|
|
|
assert(didTest);
|
|
|
|
console.log('ok');
|
|
|
|
});
|
|
|
|
|
|
|
|
r._read = function() {
|
|
|
|
setTimeout(function() {
|
|
|
|
assert(removed);
|
|
|
|
assert.throws(function() {
|
|
|
|
w.emit('error', new Error('fail'));
|
|
|
|
});
|
|
|
|
didTest = true;
|
|
|
|
});
|
|
|
|
};
|
|
|
|
|
|
|
|
w.on('error', myOnError);
|
|
|
|
r.pipe(w);
|
|
|
|
w.removeListener('error', myOnError);
|
|
|
|
removed = true;
|
|
|
|
|
|
|
|
function myOnError(er) {
|
|
|
|
throw new Error('this should not happen');
|
|
|
|
}
|
|
|
|
})();
|
|
|
|
|
|
|
|
(function testErrorWithRemovedListenerThrows() {
|
|
|
|
var R = Stream.Readable;
|
|
|
|
var W = Stream.Writable;
|
|
|
|
|
|
|
|
var r = new R();
|
|
|
|
var w = new W();
|
stream: Throw on 'error' if listeners removed
In this situation:
writable.on('error', handler);
readable.pipe(writable);
writable.removeListener('error', handler);
writable.emit('error', new Error('boom'));
there is actually no error handler, but it doesn't throw, because of the
fix for stream.once('error', handler), in 23d92ec.
Note that simply reverting that change is not valid either, because
otherwise this will emit twice, being handled the first time, and then
throwing the second:
writable.once('error', handler);
readable.pipe(writable);
writable.emit('error', new Error('boom'));
Fix this with a horrible hack to make the stream pipe onerror handler
added before any other userland handlers, so that our handler is not
affected by adding or removing any userland handlers.
Closes #6007.
12 years ago
|
|
|
var removed = false;
|
|
|
|
var didTest = false;
|
|
|
|
var caught = false;
|
|
|
|
|
|
|
|
process.on('exit', function() {
|
|
|
|
assert(didTest);
|
|
|
|
console.log('ok');
|
|
|
|
});
|
|
|
|
|
|
|
|
r._read = function() {
|
|
|
|
setTimeout(function() {
|
|
|
|
assert(removed);
|
|
|
|
w.emit('error', new Error('fail'));
|
|
|
|
didTest = true;
|
|
|
|
});
|
|
|
|
};
|
|
|
|
|
|
|
|
w.on('error', myOnError);
|
|
|
|
w._write = function() {};
|
|
|
|
|
|
|
|
r.pipe(w);
|
|
|
|
// Removing some OTHER random listener should not do anything
|
|
|
|
w.removeListener('error', function() {});
|
|
|
|
removed = true;
|
|
|
|
|
|
|
|
function myOnError(er) {
|
|
|
|
assert(!caught);
|
|
|
|
caught = true;
|
|
|
|
}
|
|
|
|
})();
|