lukechilds
/
node
mirror of https://github.com/lukechilds/node.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
15841 Commits
131 Branches
446 Tags
325 MiB
Tree: 7c0d5d5fd9
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '7c0d5d5fd9'
${ noResults }
node/test/parallel/test-net-better-error-messa...

15 lines
375 B
Raw Normal View History

test: enable linting for tests Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: https://github.com/nodejs/io.js/pull/1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
10 years ago
'use strict';
test: var -> let/const, .equal -> .strictEqual var -> let/const .equal -> .strictEqual PR-URL: https://github.com/nodejs/node/pull/9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago
const common = require('../common');
const net = require('net');
const assert = require('assert');
net: give better error messages Add address and/or port to errors where applicable for better reporting. In the event the local address and port are accessible, it will also add those to the error message. See joyent/node#7005 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/iojs/io.js/pull/35
10 years ago
test: var -> let/const, .equal -> .strictEqual var -> let/const .equal -> .strictEqual PR-URL: https://github.com/nodejs/node/pull/9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago
const c = net.createConnection(common.PORT);
net: give better error messages Add address and/or port to errors where applicable for better reporting. In the event the local address and port are accessible, it will also add those to the error message. See joyent/node#7005 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/iojs/io.js/pull/35
10 years ago
test: wrap assert.fail when passed to callback Currently there are many instances where assert.fail is directly passed to a callback for error handling. Unfortunately this will swallow the error as it is the third argument of assert.fail that sets the message not the first. This commit adds a new function to test/common.js that simply wraps assert.fail and calls it with the provided message. Tip of the hat to @trott for pointing me in the direction of this. PR-URL: https://github.com/nodejs/node/pull/3453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
9 years ago
c.on('connect', common.fail);
net: give better error messages Add address and/or port to errors where applicable for better reporting. In the event the local address and port are accessible, it will also add those to the error message. See joyent/node#7005 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/iojs/io.js/pull/35
10 years ago
c.on('error', common.mustCall(function(e) {
test: var -> let/const, .equal -> .strictEqual var -> let/const .equal -> .strictEqual PR-URL: https://github.com/nodejs/node/pull/9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago
assert.strictEqual(e.code, 'ECONNREFUSED');
assert.strictEqual(e.port, common.PORT);
assert.strictEqual(e.address, '127.0.0.1');
net: give better error messages Add address and/or port to errors where applicable for better reporting. In the event the local address and port are accessible, it will also add those to the error message. See joyent/node#7005 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/iojs/io.js/pull/35
10 years ago
}));