|
|
|
/**
|
|
|
|
* @fileoverview Rule to flag trailing underscores in variable declarations.
|
|
|
|
* @author Matt DuVall <http://www.mattduvall.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
"use strict";
|
|
|
|
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
// Rule Definition
|
|
|
|
//------------------------------------------------------------------------------
|
|
|
|
|
|
|
|
module.exports = {
|
|
|
|
meta: {
|
|
|
|
docs: {
|
|
|
|
description: "disallow dangling underscores in identifiers",
|
|
|
|
category: "Stylistic Issues",
|
|
|
|
recommended: false
|
|
|
|
},
|
|
|
|
|
|
|
|
schema: [
|
|
|
|
{
|
|
|
|
type: "object",
|
|
|
|
properties: {
|
|
|
|
allow: {
|
|
|
|
type: "array",
|
|
|
|
items: {
|
|
|
|
type: "string"
|
|
|
|
}
|
|
|
|
},
|
|
|
|
allowAfterThis: {
|
|
|
|
type: "boolean"
|
|
|
|
},
|
|
|
|
allowAfterSuper: {
|
|
|
|
type: "boolean"
|
|
|
|
}
|
|
|
|
},
|
|
|
|
additionalProperties: false
|
|
|
|
}
|
|
|
|
]
|
|
|
|
},
|
|
|
|
|
|
|
|
create: function(context) {
|
|
|
|
|
|
|
|
let options = context.options[0] || {};
|
|
|
|
let ALLOWED_VARIABLES = options.allow ? options.allow : [];
|
|
|
|
let allowAfterThis = typeof options.allowAfterThis !== "undefined" ? options.allowAfterThis : false;
|
|
|
|
let allowAfterSuper = typeof options.allowAfterSuper !== "undefined" ? options.allowAfterSuper : false;
|
|
|
|
|
|
|
|
//-------------------------------------------------------------------------
|
|
|
|
// Helpers
|
|
|
|
//-------------------------------------------------------------------------
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Check if identifier is present inside the allowed option
|
|
|
|
* @param {string} identifier name of the node
|
|
|
|
* @returns {boolean} true if its is present
|
|
|
|
* @private
|
|
|
|
*/
|
|
|
|
function isAllowed(identifier) {
|
|
|
|
return ALLOWED_VARIABLES.some(function(ident) {
|
|
|
|
return ident === identifier;
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Check if identifier has a underscore at the end
|
|
|
|
* @param {ASTNode} identifier node to evaluate
|
|
|
|
* @returns {boolean} true if its is present
|
|
|
|
* @private
|
|
|
|
*/
|
|
|
|
function hasTrailingUnderscore(identifier) {
|
|
|
|
let len = identifier.length;
|
|
|
|
|
|
|
|
return identifier !== "_" && (identifier[0] === "_" || identifier[len - 1] === "_");
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Check if identifier is a special case member expression
|
|
|
|
* @param {ASTNode} identifier node to evaluate
|
|
|
|
* @returns {boolean} true if its is a special case
|
|
|
|
* @private
|
|
|
|
*/
|
|
|
|
function isSpecialCaseIdentifierForMemberExpression(identifier) {
|
|
|
|
return identifier === "__proto__";
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Check if identifier is a special case variable expression
|
|
|
|
* @param {ASTNode} identifier node to evaluate
|
|
|
|
* @returns {boolean} true if its is a special case
|
|
|
|
* @private
|
|
|
|
*/
|
|
|
|
function isSpecialCaseIdentifierInVariableExpression(identifier) {
|
|
|
|
|
|
|
|
// Checks for the underscore library usage here
|
|
|
|
return identifier === "_";
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Check if function has a underscore at the end
|
|
|
|
* @param {ASTNode} node node to evaluate
|
|
|
|
* @returns {void}
|
|
|
|
* @private
|
|
|
|
*/
|
|
|
|
function checkForTrailingUnderscoreInFunctionDeclaration(node) {
|
|
|
|
if (node.id) {
|
|
|
|
let identifier = node.id.name;
|
|
|
|
|
|
|
|
if (typeof identifier !== "undefined" && hasTrailingUnderscore(identifier) && !isAllowed(identifier)) {
|
|
|
|
context.report(node, "Unexpected dangling '_' in '" + identifier + "'.");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Check if variable expression has a underscore at the end
|
|
|
|
* @param {ASTNode} node node to evaluate
|
|
|
|
* @returns {void}
|
|
|
|
* @private
|
|
|
|
*/
|
|
|
|
function checkForTrailingUnderscoreInVariableExpression(node) {
|
|
|
|
let identifier = node.id.name;
|
|
|
|
|
|
|
|
if (typeof identifier !== "undefined" && hasTrailingUnderscore(identifier) &&
|
|
|
|
!isSpecialCaseIdentifierInVariableExpression(identifier) && !isAllowed(identifier)) {
|
|
|
|
context.report(node, "Unexpected dangling '_' in '" + identifier + "'.");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Check if member expression has a underscore at the end
|
|
|
|
* @param {ASTNode} node node to evaluate
|
|
|
|
* @returns {void}
|
|
|
|
* @private
|
|
|
|
*/
|
|
|
|
function checkForTrailingUnderscoreInMemberExpression(node) {
|
|
|
|
let identifier = node.property.name,
|
|
|
|
isMemberOfThis = node.object.type === "ThisExpression",
|
|
|
|
isMemberOfSuper = node.object.type === "Super";
|
|
|
|
|
|
|
|
if (typeof identifier !== "undefined" && hasTrailingUnderscore(identifier) &&
|
|
|
|
!(isMemberOfThis && allowAfterThis) &&
|
|
|
|
!(isMemberOfSuper && allowAfterSuper) &&
|
|
|
|
!isSpecialCaseIdentifierForMemberExpression(identifier) && !isAllowed(identifier)) {
|
|
|
|
context.report(node, "Unexpected dangling '_' in '" + identifier + "'.");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
//--------------------------------------------------------------------------
|
|
|
|
// Public API
|
|
|
|
//--------------------------------------------------------------------------
|
|
|
|
|
|
|
|
return {
|
|
|
|
FunctionDeclaration: checkForTrailingUnderscoreInFunctionDeclaration,
|
|
|
|
VariableDeclarator: checkForTrailingUnderscoreInVariableExpression,
|
|
|
|
MemberExpression: checkForTrailingUnderscoreInMemberExpression
|
|
|
|
};
|
|
|
|
|
|
|
|
}
|
|
|
|
};
|