mirror of https://github.com/lukechilds/node.git
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
47 lines
1.2 KiB
47 lines
1.2 KiB
8 years ago
|
/**
|
||
|
* @fileoverview Prohibit the use of `let` as the loop variable
|
||
|
* in the initialization of for, and the left-hand
|
||
|
* iterator in forIn and forOf loops.
|
||
|
*
|
||
|
* @author Jessica Quynh Tran
|
||
|
*/
|
||
|
|
||
|
'use strict';
|
||
|
|
||
|
//------------------------------------------------------------------------------
|
||
|
// Rule Definition
|
||
|
//------------------------------------------------------------------------------
|
||
|
|
||
|
module.exports = {
|
||
|
create(context) {
|
||
|
|
||
|
const msg = 'Use of `let` as the loop variable in a for-loop is ' +
|
||
|
'not recommended. Please use `var` instead.';
|
||
|
|
||
|
/**
|
||
|
* Report function to test if the for-loop is declared using `let`.
|
||
|
*/
|
||
|
function testForLoop(node) {
|
||
|
if (node.init && node.init.kind === 'let') {
|
||
|
context.report(node.init, msg);
|
||
|
}
|
||
|
}
|
||
|
|
||
|
/**
|
||
|
* Report function to test if the for-in or for-of loop
|
||
|
* is declared using `let`.
|
||
|
*/
|
||
|
function testForInOfLoop(node) {
|
||
|
if (node.left && node.left.kind === 'let') {
|
||
|
context.report(node.left, msg);
|
||
|
}
|
||
|
}
|
||
|
|
||
|
return {
|
||
|
'ForStatement': testForLoop,
|
||
|
'ForInStatement': testForInOfLoop,
|
||
|
'ForOfStatement': testForInOfLoop
|
||
|
};
|
||
|
}
|
||
|
};
|