node/test/known_issues/test-vm-attributes-property...

'use strict';
require('../common');
const assert = require('assert');
const vm = require('vm');

// The QueryCallback explicitly calls GetRealNamedPropertyAttributes
// on the global proxy if the property is not found on the sandbox.
//
// foo is not defined on the sandbox until we call CopyProperties().
// In the QueryCallback, we do not find the property on the sandbox
// and look up its PropertyAttributes on the global_proxy().
// PropertyAttributes are always flattened to a value
// descriptor.
const sandbox = {};
vm.createContext(sandbox);
const code = `Object.defineProperty(
               this,
               'foo',
               { get: function() {return 17} }
             );
             var desc = Object.getOwnPropertyDescriptor(this, 'foo');`;

vm.runInContext(code, sandbox);
// The descriptor is flattened. We wrongly have typeof desc.value = 'number'.
assert.strictEqual(typeof sandbox.desc.get, 'function');
test: add vm module edge cases Add two, admittedly contrived, examples that test edge cases of the vm module. They demonstrate that the if statements `if (maybe_rv.IsEmpty())` and `if (maybe_prop_attr.IsNothing())` in the GetterCallback and the QueryCallback are observable. Both GetterCallback and QueryCallback explicitly check the global_proxy() if a property is not found on the sandbox. In these tests, the explicit check inside the callback yields different results than deferring the check until after the callback. The check is deferred, if the callbacks do not intercept, i.e., if args.GetReturnValue().Set() is not called. PR-URL: https://github.com/nodejs/node/pull/11265 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> 8 years ago			`'use strict';`
			`require('../common');`
			`const assert = require('assert');`
			`const vm = require('vm');`

			`// The QueryCallback explicitly calls GetRealNamedPropertyAttributes`
			`// on the global proxy if the property is not found on the sandbox.`
			`//`
			`// foo is not defined on the sandbox until we call CopyProperties().`
			`// In the QueryCallback, we do not find the property on the sandbox`
			`// and look up its PropertyAttributes on the global_proxy().`
			`// PropertyAttributes are always flattened to a value`
			`// descriptor.`
			`const sandbox = {};`
			`vm.createContext(sandbox);`
			const code = `Object.defineProperty(
			`this,`
			`'foo',`
			`{ get: function() {return 17} }`
			`);`
			var desc = Object.getOwnPropertyDescriptor(this, 'foo');`;

			`vm.runInContext(code, sandbox);`
			`// The descriptor is flattened. We wrongly have typeof desc.value = 'number'.`
			`assert.strictEqual(typeof sandbox.desc.get, 'function');`