|
|
|
// Copyright Joyent, Inc. and other Node contributors.
|
|
|
|
//
|
|
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
// copy of this software and associated documentation files (the
|
|
|
|
// "Software"), to deal in the Software without restriction, including
|
|
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
|
|
// following conditions:
|
|
|
|
//
|
|
|
|
// The above copyright notice and this permission notice shall be included
|
|
|
|
// in all copies or substantial portions of the Software.
|
|
|
|
//
|
|
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
|
|
|
|
|
|
|
|
var common = require('../common');
|
|
|
|
var assert = require('assert');
|
|
|
|
var cluster = require('cluster');
|
|
|
|
|
|
|
|
if (cluster.isWorker) {
|
|
|
|
|
|
|
|
// keep the worker alive
|
|
|
|
var http = require('http');
|
|
|
|
http.Server().listen(common.PORT, '127.0.0.1');
|
|
|
|
|
|
|
|
} else if (process.argv[2] === 'cluster') {
|
|
|
|
|
|
|
|
var worker = cluster.fork();
|
|
|
|
|
|
|
|
// send PID info to testcase process
|
|
|
|
process.send({
|
|
|
|
pid: worker.process.pid
|
|
|
|
});
|
|
|
|
|
|
|
|
// terminate the cluster process
|
|
|
|
worker.once('listening', function() {
|
|
|
|
setTimeout(function() {
|
|
|
|
process.exit(0);
|
|
|
|
}, 1000);
|
|
|
|
});
|
|
|
|
|
|
|
|
} else {
|
|
|
|
|
|
|
|
// This is the testcase
|
|
|
|
var fork = require('child_process').fork;
|
|
|
|
|
|
|
|
// is process alive helper
|
|
|
|
var isAlive = function(pid) {
|
|
|
|
try {
|
|
|
|
//this will throw an error if the process is dead
|
|
|
|
process.kill(pid, 0);
|
|
|
|
|
|
|
|
return true;
|
|
|
|
} catch (e) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
// Spawn a cluster process
|
|
|
|
var master = fork(process.argv[1], ['cluster']);
|
|
|
|
|
|
|
|
// get pid info
|
|
|
|
var pid = null;
|
|
|
|
master.once('message', function(data) {
|
|
|
|
pid = data.pid;
|
|
|
|
});
|
|
|
|
|
|
|
|
// When master is dead
|
|
|
|
var alive = true;
|
|
|
|
master.on('exit', function(code) {
|
|
|
|
|
|
|
|
// make sure that the master died by purpose
|
|
|
|
assert.equal(code, 0);
|
|
|
|
|
|
|
|
// check worker process status
|
|
|
|
setTimeout(function() {
|
|
|
|
alive = isAlive(pid);
|
test: make cluster tests more time tolerant
simple tests test-cluster-master-error.js, test-cluster-master-kill.js
fails in AIX with assertion failure indicating that the workers were
alive even after the master terminated. A 200ms leeway is provided for
the workers to actually terminate, but the isAlive check returns
true in both the cases.
In AIX, the workers were actually terminating, but they took more time
- as much as 800ms (normal) to 1000ms (in rare cases).
Based on a C test we ran, it is found that the exit routines in AIX
is a bit more longer than that in Linux. There are a number of cleanup
activities performed in exit() system call, and depending on when the
signal handlers are shutdown in that sequence, the process will be
deemed as dead or alive, from another process's perspective.
process.kill(pid) is used in the test case to check the liveliness of
the worker, and when the kill() call is issued, even if the target
process is in it's exit sequences, if the signal handlers are not shut
down, it will respond to external signals, causing those calls to pass.
This fix extends the additional timeout for all platforms
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: https://github.com/joyent/node/pull/9431
10 years ago
|
|
|
}, 1000);
|
|
|
|
});
|
|
|
|
|
|
|
|
process.once('exit', function() {
|
|
|
|
// cleanup: kill the worker if alive
|
|
|
|
if (alive) {
|
|
|
|
process.kill(pid);
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.equal(typeof pid, 'number', 'did not get worker pid info');
|
|
|
|
assert.equal(alive, false, 'worker was alive after master died');
|
|
|
|
});
|
|
|
|
|
|
|
|
}
|