You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
|
|
|
|
### Pull Request check-list
|
|
|
|
|
|
|
|
|
|
_Please make sure to review and check all of these items:_
|
|
|
|
|
|
|
|
|
|
- [ ] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with
|
|
|
|
|
this change (including linting)?
|
|
|
|
|
- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0]?
|
|
|
|
|
- [ ] If this change fixes a bug (or a performance problem), is a regression
|
|
|
|
|
test (or a benchmark) included?
|
|
|
|
|
- [ ] Is a documentation update included (if this change modifies
|
|
|
|
|
existing APIs, or introduces new ones)?
|
|
|
|
|
|
|
|
|
|
_NOTE: these things are not required to open a PR and can be done
|
|
|
|
|
afterwards / while the PR is open._
|
|
|
|
|
|
|
|
|
|
### Affected core subsystem(s)
|
|
|
|
|
|
|
|
|
|
_Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)_
|
|
|
|
|
|
|
|
|
|
[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit
|
|
|
|
|
|
|
|
|
|
### Description of change
|
|
|
|
|
|
|
|
|
|
_Please provide a description of the change here._
|
