Browse Source
doc: consolidate test/lint text in GH PR template
PR-URL: https://github.com/nodejs/node/pull/7155
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Rich Trott
9 years ago
Julian Duque
GPG Key ID:
1 changed files with
1 additions and
3 deletions
.github/PULL_REQUEST_TEMPLATE.md
@ -1,8 +1,6 @@
<!-- <!--
Thank you for your pull request. Please review below requirements.Thank you for your pull request. Please review below requirements.
Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.
If this aims to fix a regression or you’re adding a feature, make sure you alsoIf this aims to fix a regression or you’re adding a feature, make sure you also
write a test. If possible, include a benchmark that quantifies your changes.write a test. If possible, include a benchmark that quantifies your changes.
@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
##### Checklist##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> <!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [ ] tests and code linting passes- [ ] `make -j4 test` (UNIX) or `vcbuild test nosign` (Windows)
- [ ] a test and/or benchmark is included- [ ] a test and/or benchmark is included
- [ ] documentation is changed or added- [ ] documentation is changed or added
- [ ] the commit message follows commit guidelines- [ ] the commit message follows commit guidelines
Rich Trott
9 years ago
Julian Duque