From 05f17db8b2c57ae86d1043ca8009a34c3cd2f611 Mon Sep 17 00:00:00 2001 From: Shigeki Ohtsu Date: Tue, 5 Jan 2016 18:11:19 +0900 Subject: [PATCH] tools: fix warning in doc parsing The description of "[start[, end]]" in the doc shows warning of "invalid param" when parsing an optional parameter in the section. This fixes insufficient trimming of right square brackets. PR-URL: https://github.com/nodejs/node/pull/4537 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- tools/doc/json.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/doc/json.js b/tools/doc/json.js index 4c57aefd79..07aef469f3 100644 --- a/tools/doc/json.js +++ b/tools/doc/json.js @@ -283,7 +283,7 @@ function parseSignature(text, sig) { // [foo] -> optional if (p.charAt(p.length - 1) === ']') { optional = true; - p = p.substr(0, p.length - 1); + p = p.replace(/\]/g, ''); p = p.trim(); } var eq = p.indexOf('=');