mirror of https://github.com/lukechilds/node.git
Browse Source
The allowHalfOpen comment was added in commit 8a3befa
("net: Refactor
to use streams2") from 2012 but it wasn't true even then as far as I
can tell: Node.js simply always does a shutdown(2) first.
It is true that streams2 withholds the 'end' event when allowHalfOpen
is true but the comment is about a callback that hangs off the 'finish'
event that is emitted after calling `socket.end()`.
PR-URL: https://github.com/nodejs/node/pull/11573
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
v6.x
Ben Noordhuis
8 years ago
committed by
Myles Borins
1 changed files with 0 additions and 4 deletions
Loading…
Reference in new issue