From 0899ea7a5210be333ed13c730a179a86e48a56a0 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 18 Apr 2016 22:37:35 -0400 Subject: [PATCH] deps: exclude tests on ppc for v8 5.0 There were 2 issues which either the v8 team was reluctant to backport the fix because the fix was for a disabled feature (wasm) or that we did not have time to investigate before 5.0 was cut which result in v8 test failures for PPC in 5.0. These are test issues and are already resolved in v8 master. This PR excludes these tests so that our v8 tests in the CI will be green so that we can detect any real regressions. PR-URL: https://github.com/nodejs/node/pull/6267 Fixes: https://github.com/nodejs/node/issues/6236 Reviewed-By: Ben Noordhuis Reviewed-By: James M Snell Reviewed-By: Colin Ihrig --- deps/v8/test/cctest/cctest.status | 7 +++++++ deps/v8/test/mjsunit/mjsunit.status | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/deps/v8/test/cctest/cctest.status b/deps/v8/test/cctest/cctest.status index 8eaa9515b1..88b2750a54 100644 --- a/deps/v8/test/cctest/cctest.status +++ b/deps/v8/test/cctest/cctest.status @@ -615,4 +615,11 @@ 'test-api/InitializeDefaultIsolateOnSecondaryThread1': [PASS, ['mode == debug', FAIL]], }], +############################################################################## +# exclude test issues for which fixes for PPC did not make it into 5.0 +# These should be removed when we upgrade Node.js to use v8 5.1 +['arch == ppc64', { + 'test-heap/ReleaseOverReservedPages' : [SKIP], +}], # 'arch == ppc64'' + ] diff --git a/deps/v8/test/mjsunit/mjsunit.status b/deps/v8/test/mjsunit/mjsunit.status index e638f5645b..21d14c0a3e 100644 --- a/deps/v8/test/mjsunit/mjsunit.status +++ b/deps/v8/test/mjsunit/mjsunit.status @@ -923,4 +923,11 @@ 'big-array-literal': [SKIP], }], # 'gcov_coverage' +############################################################################## +# exclude test issues for which fixes for PPC did not make it into 5.0 +# These should be removed when we upgrade Node.js to use v8 5.1 +['arch == ppc64', { + 'wasm/asm-wasm' : [SKIP], +}], # 'arch == ppc64'' + ]